Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API] Firewall: support IP ranges and accept/drop #2966

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Wekkser
Copy link

@Wekkser Wekkser commented Feb 26, 2025

This pull request introduces enhancements to the firewall package, including the addition of support for IP ranges and new filter actions.

Improvements to IP value handling:

  • Added support for IP ranges by introducing a new IPValueTypeRange constant and updating the GetIPValueType function to recognize IP ranges.

  • Updated the applyMatchIP function to handle IP ranges and added the applyMatchIPRange function for applying IP range matches.

Enhancements to firewall actions:

  • Added new filter actions ActionAccept and ActionDrop to the FilterAction enum and updated the FilterRule struct to include these actions.

  • Implemented the applyAcceptAction and applyDropAction functions to apply the new accept and drop actions in the firewall rules.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • Test A
  • Test B

@adamjensenbot
Copy link
Collaborator

Hi @Wekkser. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • feat: 🚀 New Feature
  • fix: 🐛 Bug Fix
  • refactor: 🧹 Code Refactoring
  • docs: 📝 Documentation
  • style: 💄 Code Style
  • perf: 🐎 Performance Improvement
  • test: ✅ Tests
  • chore: 🚚 Dependencies Management
  • build: 📦 Builds Management
  • ci: 👷 CI/CD
  • revert: ⏪ Reverts Previous Changes

@github-actions github-actions bot added the feat Adds a new feature to the codebase label Feb 26, 2025
@Wekkser Wekkser marked this pull request as draft February 26, 2025 16:25
@Wekkser Wekkser changed the title Wks/actions filter Filter actions and IP range Feb 26, 2025
@Wekkser Wekkser changed the title Filter actions and IP range [API] Firewall: support IP ranges and accept/drop Feb 26, 2025
@pull-request-size pull-request-size bot added size/L and removed size/M labels Mar 4, 2025
@Wekkser Wekkser force-pushed the wks/actions_filter branch from 932b8aa to 663eb96 Compare March 5, 2025 15:11
@Wekkser Wekkser force-pushed the wks/actions_filter branch from 663eb96 to 7d5731e Compare March 5, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Adds a new feature to the codebase size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants