Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API] Make Tenant namespace-scoped #2963

Merged

Conversation

claudiolor
Copy link
Contributor

@claudiolor claudiolor commented Feb 25, 2025

Description

This PR changes the API to make the Tenant resource namespace-scoped.
The reasons for this are the following:

  • When the tenant namespace is deleted, all the resources related to the tenant can be deleted
  • When creating peering connection, changes can be limited only to the tenant-namespace

Moreover, a webhook has been added to make sure that the Tenant resource is created in a Tenant namespace with matching cluster ID and to make sure that the Tenant has unique name across the cluster.

How Has This Been Tested?

Added test suite for the new webhook.
Manual and automated e2e tests have been performed.

@adamjensenbot
Copy link
Collaborator

Hi @claudiolor. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • feat: 🚀 New Feature
  • fix: 🐛 Bug Fix
  • refactor: 🧹 Code Refactoring
  • docs: 📝 Documentation
  • style: 💄 Code Style
  • perf: 🐎 Performance Improvement
  • test: ✅ Tests
  • chore: 🚚 Dependencies Management
  • build: 📦 Builds Management
  • ci: 👷 CI/CD
  • revert: ⏪ Reverts Previous Changes

@github-actions github-actions bot added fix Fixes a bug in the codebase. refactor Reorganizes or optimizes code without changing its behavior labels Feb 25, 2025
@claudiolor claudiolor force-pushed the clo/make-tenant-namespaced branch from c0adfd1 to 90ef4f6 Compare February 26, 2025 09:05
@claudiolor
Copy link
Contributor Author

/build

@claudiolor claudiolor force-pushed the clo/make-tenant-namespaced branch 3 times, most recently from 2544ddf to 0663b94 Compare February 27, 2025 11:37
@claudiolor
Copy link
Contributor Author

/build

@claudiolor claudiolor force-pushed the clo/make-tenant-namespaced branch from 0663b94 to a1199bf Compare February 28, 2025 15:55
@github-actions github-actions bot added chore Miscellaneous tasks that don't modify application logic (e.g., updating dependencies or build tasks) test Adds or updates tests for the codebase labels Feb 28, 2025
@claudiolor
Copy link
Contributor Author

/test

@claudiolor claudiolor force-pushed the clo/make-tenant-namespaced branch from 987a497 to 6bb659d Compare March 6, 2025 11:48
@claudiolor claudiolor marked this pull request as ready for review March 6, 2025 11:54
@claudiolor claudiolor force-pushed the clo/make-tenant-namespaced branch 2 times, most recently from f667ed7 to 60f071d Compare March 7, 2025 11:32
@github-actions github-actions bot removed fix Fixes a bug in the codebase. chore Miscellaneous tasks that don't modify application logic (e.g., updating dependencies or build tasks) refactor Reorganizes or optimizes code without changing its behavior test Adds or updates tests for the codebase labels Mar 7, 2025
@claudiolor claudiolor force-pushed the clo/make-tenant-namespaced branch from 60f071d to facf4ff Compare March 7, 2025 12:07
@claudiolor claudiolor force-pushed the clo/make-tenant-namespaced branch from bb124a3 to 33f04fc Compare March 7, 2025 12:18
@fra98
Copy link
Member

fra98 commented Mar 7, 2025

/test

@fra98 fra98 added breaking Breaking change refactor Reorganizes or optimizes code without changing its behavior labels Mar 7, 2025
@fra98
Copy link
Member

fra98 commented Mar 7, 2025

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Mar 7, 2025
@adamjensenbot adamjensenbot merged commit 4261ee3 into liqotech:master Mar 7, 2025
14 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change refactor Reorganizes or optimizes code without changing its behavior size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants