-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[API] Make Tenant namespace-scoped #2963
Merged
adamjensenbot
merged 1 commit into
liqotech:master
from
claudiolor:clo/make-tenant-namespaced
Mar 7, 2025
Merged
[API] Make Tenant namespace-scoped #2963
adamjensenbot
merged 1 commit into
liqotech:master
from
claudiolor:clo/make-tenant-namespaced
Mar 7, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @claudiolor. Thanks for your PR! I am @adamjensenbot.
Make sure this PR appears in the liqo changelog, adding one of the following labels:
|
c0adfd1
to
90ef4f6
Compare
/build |
2544ddf
to
0663b94
Compare
/build |
0663b94
to
a1199bf
Compare
/test |
987a497
to
6bb659d
Compare
cheina97
reviewed
Mar 7, 2025
pkg/liqo-controller-manager/authentication/tenant-controller/tenant_controller.go
Outdated
Show resolved
Hide resolved
cheina97
approved these changes
Mar 7, 2025
f667ed7
to
60f071d
Compare
fra98
approved these changes
Mar 7, 2025
60f071d
to
facf4ff
Compare
bb124a3
to
33f04fc
Compare
/test |
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the API to make the Tenant resource namespace-scoped.
The reasons for this are the following:
Moreover, a webhook has been added to make sure that the Tenant resource is created in a Tenant namespace with matching cluster ID and to make sure that the Tenant has unique name across the cluster.
How Has This Been Tested?
Added test suite for the new webhook.
Manual and automated e2e tests have been performed.