Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use WinAPI functions on Windows #8

Open
lionkor opened this issue Mar 8, 2022 · 0 comments · May be fixed by #47
Open

Use WinAPI functions on Windows #8

lionkor opened this issue Mar 8, 2022 · 0 comments · May be fixed by #47
Labels
enhancement New feature or request

Comments

@lionkor
Copy link
Owner

lionkor commented Mar 8, 2022

Currently we're using ANSI escape codes on both Unix/Linux/MacOS and Windows, which causes issues in Windows (of course).

They decided that Powershell and the Windows Terminal (!= CMD) should not behave properly when presented with ANSI escape codes, even with that feature explicitly enabled.

So, instead of getting really angry with windows' decisions, we are just going to use their WinAPI features to do what we do with ANSI escape sequences currently.

Snarkiness aside, the goal is to replace all ANSI escape codes (\0x1b prefixed stuff in all calls to printf) with the equivalent Windows API function call.

@lionkor lionkor added the enhancement New feature or request label Mar 15, 2022
Melnytskyi added a commit to Melnytskyi/commandline that referenced this issue Jul 1, 2024
@Melnytskyi Melnytskyi linked a pull request Jul 1, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant