This repository has been archived by the owner on Nov 23, 2023. It is now read-only.
feat: Better logging and exception handling in populate catalog #2084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l0b0
reviewed
Sep 30, 2022
Jimlinz
added a commit
that referenced
this pull request
Oct 2, 2022
l0b0
reviewed
Oct 4, 2022
Jimlinz
added a commit
that referenced
this pull request
Oct 4, 2022
Jimlinz
force-pushed
the
feat/better-logging-exception-handling-populate-catalog
branch
from
b1d6a85 to
8e8e66a
Compare
l0b0
reviewed
Oct 4, 2022
Jimlinz
force-pushed
the
feat/better-logging-exception-handling-populate-catalog
branch
from
8e8e66a to
eab5a16
Compare
l0b0
approved these changes
Oct 5, 2022
kodiakhq
bot
deleted the
feat/better-logging-exception-handling-populate-catalog
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
populate_cataloglambda fails, messages get stuck in SQS. This prevents subsequent datasets from being added to geostore (in completion). Without alerting in place, the problem persists until someone notices it.This PR implements better logging and exception handling in
populate_catalog. The logs should capture when an exception is thrown. Elasticsearch should monitor for such problem and alert the geostore team accordingly.Reference
Code review checklist