Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nextcloud: update WebDAV URL redirects for subfolder #673

Closed
wants to merge 1 commit into from

Conversation

h9419
Copy link

@h9419 h9419 commented Apr 28, 2024

linuxserver.io


  • I have read the contributing guideline and understand that I have made the correct modifications

Description

There's existing redirect from /.well-known/carddav and /.well-known/caldav to /nextcloud/remote.php/dav/.

However, in Nextcloud version 29, it will check for /nextcloud/.well-known/carddav which Nextcloud will then resolve to /remote.php/dav/ regardless of overwritewebroot config and will not reach the Nextcloud endpoint.

Benefits of this PR and context

Removes a warning in Nextcloud's "Security & setup warnings" page

How Has This Been Tested?

Removes the warning on my configuration with default lscr.io/linuxserver/swag:2.10.0 and lscr.io/linuxserver/nextcloud:29.0.0

Source / References

@LinuxServer-CI
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@h9419
Copy link
Author

h9419 commented Jun 2, 2024

This is still a nice-to-have PR

As detailed in nextcloud/server#45033 (comment) and nextcloud/server#45033 (comment), Nextcloud 29 starts performing the WebDAV verifications with overwrite.cli.url which is advised to be the same as the URL in which Nextcloud is accessed through

As such, yourhost.com/subfolder/.well-known/carddav will be queried.

I have a question for contributors such as @aptalca, I am just not sure what needs to be done to get this approved

@LinuxServer-CI
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

Copy link

github-actions bot commented Oct 1, 2024

This pull request is locked due to inactivity

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Development

Successfully merging this pull request may close these issues.

2 participants