Secure cookies in heimdall.subdomain.conf.sample #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cookies are not secure by default with heimdall, we can force it through nginx.
d4rklynk
changed the title
nemchik
reviewed
Dec 15, 2023
There was a problem hiding this comment.
We have a similar line here https://github.com/linuxserver/docker-swag/blob/5b77a546209cab487853d3b0d3505578d11e7f52/root/defaults/nginx/proxy.conf.sample#L18 with a warning about applying it. There are some applications that have issues with this configuration, so it's not likely appropriate to be used globally (in the proxy.conf) but may be safe in an individual proxy conf for an application (like Heimdall) as you have it here.
I would prefer it to be commented out by default, with a comment description, and placed below the proxy_pass $upstream_proto://$upstream_app:$upstream_port; line
nemchik
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The cookies are not secure by default with heimdall, we can force it through nginx.
How Has This Been Tested?
The cookies are functional and can be seen through developer console on my instance -> https://services.simpleprivacy.fr/