-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: take ownership of plugin directories #214
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this pull request! Be sure to follow the pull request template!
I am a bot, here are the test results for this PR:
|
Any feedback? |
I don't see any issue with this in priciple Please add an entry to the readme-vars changelog and then I'm happy to approve and merge. |
@thespad Thanks for the feedback. I added a changelog entry. |
I am a bot, here are the test results for this PR:
|
Description:
Benefits of this PR and context:
This PR applies correct permissions to the jellyfin plugins directory, but more specifically the plugin configuration directories. Plugins for Jellyfin do not, and should not, supply the configuration directory, and should not be responsible for applying permissions on it, as if multiple plugins were added with the docker mod method, they could conflict with each other.
How Has This Been Tested?
I have not tested, the change is straight forward.
Source / References:
linuxserver/docker-mods#753 (comment)