Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: take ownership of plugin directories #214

Merged
merged 2 commits into from
Sep 12, 2023
Merged

fix: take ownership of plugin directories #214

merged 2 commits into from
Sep 12, 2023

Conversation

ReenigneArcher
Copy link
Contributor

@ReenigneArcher ReenigneArcher commented Aug 29, 2023

linuxserver.io


  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

Benefits of this PR and context:

This PR applies correct permissions to the jellyfin plugins directory, but more specifically the plugin configuration directories. Plugins for Jellyfin do not, and should not, supply the configuration directory, and should not be responsible for applying permissions on it, as if multiple plugins were added with the docker mod method, they could conflict with each other.

How Has This Been Tested?

I have not tested, the change is straight forward.

Source / References:

linuxserver/docker-mods#753 (comment)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! Be sure to follow the pull request template!

@LinuxServer-CI
Copy link
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/jellyfin/10.8.10-1-pkg-f3c3b90b-dev-8a8c8e695cb1e6a3eccab3db38b866f64adac72a-pr-214/index.html
https://ci-tests.linuxserver.io/lspipepr/jellyfin/10.8.10-1-pkg-f3c3b90b-dev-8a8c8e695cb1e6a3eccab3db38b866f64adac72a-pr-214/shellcheck-result.xml

Tag Passed
amd64-10.8.10-1-pkg-f3c3b90b-dev-8a8c8e695cb1e6a3eccab3db38b866f64adac72a-pr-214
arm64v8-10.8.10-1-pkg-f3c3b90b-dev-8a8c8e695cb1e6a3eccab3db38b866f64adac72a-pr-214

@ReenigneArcher
Copy link
Contributor Author

Any feedback?

@thespad
Copy link
Member

thespad commented Sep 12, 2023

I don't see any issue with this in priciple how many files make up the average plugin? My only concern would be startup performance impact if the user has thousands of files under the plugin folder structure. Ignore that, we're not doing a recursive chown.

Please add an entry to the readme-vars changelog and then I'm happy to approve and merge.

@thespad thespad self-assigned this Sep 12, 2023
@ReenigneArcher
Copy link
Contributor Author

@thespad Thanks for the feedback. I added a changelog entry.

@LinuxServer-CI
Copy link
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/jellyfin/10.8.10-1-pkg-a1bf5c83-dev-f0f6dffac533c8089a58e2c98b253bb4cc8c25b1-pr-214/index.html
https://ci-tests.linuxserver.io/lspipepr/jellyfin/10.8.10-1-pkg-a1bf5c83-dev-f0f6dffac533c8089a58e2c98b253bb4cc8c25b1-pr-214/shellcheck-result.xml

Tag Passed
amd64-10.8.10-1-pkg-a1bf5c83-dev-f0f6dffac533c8089a58e2c98b253bb4cc8c25b1-pr-214
arm64v8-10.8.10-1-pkg-a1bf5c83-dev-f0f6dffac533c8089a58e2c98b253bb4cc8c25b1-pr-214

@thespad thespad merged commit a40fcd9 into linuxserver:master Sep 12, 2023
4 checks passed
@ReenigneArcher ReenigneArcher deleted the patch-1 branch September 12, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants