Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Domoticz Enhanced App #35

Merged
merged 1 commit into from
Feb 16, 2019
Merged

Conversation

SenorSmartyPants
Copy link
Contributor

Live stats supported from devices that report CounterToday and Usage.

There are a couple non-localized strings in the blade files. Not sure how you wanted to handle that. I looked in https://github.com/linuxserver/Heimdall/blob/master/resources/lang/en/app.php but there weren't any matches.

Live stats supported from devices that report CounterToday and Usage
@KodeStar
Copy link
Member

KodeStar commented Feb 15, 2019

you could add a resources/lang/en/domoticz.php, then if you had something like

<?php
return [
    'deviceidx' => 'Device Idx'
];

then in the blade you would use <label>{{ __('domoticz.deviceidx') }}</label>

@SenorSmartyPants
Copy link
Contributor Author

Would resources/lang/en/domoticz.php be created in the Heimdall repo? If so, I don't think that's a great way to keep the apps separated from the main code base.

I took a look at several of the other enhanced apps. None that I saw use localization for strings that aren't already provided in the Heimdall repo. Livestat labels like "seed" and "queue" are hard coded. As is "Test" in config.blade.php.

If you define an official procedure for what to do about non-localized app specific strings I'd be happy to follow it. But for now I'm fine with leaving a couple hard coded strings in this app since it would not set a new precedent.

@KodeStar
Copy link
Member

Fair enough, and yeah, you are right, it needs thinking about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants