Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: changed paletteType's config value #226

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

18202781743
Copy link
Contributor

We only save config's value when caller update paletteType manually.

  We only save config's value when caller update paletteType manually.
@18202781743 18202781743 requested a review from kegechen February 28, 2024 09:50
deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Feb 28, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#226
@kegechen
Copy link
Contributor

这个只是不在初始化时不保存 dconfig,但是 d->setPaletteType 还是会执行,也就是终端启动 dcc 还是黑色的。
像终端启动的 deepin-home 这种主动调用 setPaletteType 的应用一样会影响终端的调色板及 dconfig。

最终还是得靠提供接口让dcc设置自己的 appid, 或许 qApp->setProperty("_d_appid", "org.deepin.dde.control-center")
@zccrs

@18202781743
Copy link
Contributor Author

这个只是不在初始化时不保存 dconfig,但是 d->setPaletteType 还是会执行,也就是终端启动 dcc 还是黑色的。 像终端启动的 deepin-home 这种主动调用 setPaletteType 的应用一样会影响终端的调色板及 dconfig。

最终还是得靠提供接口让dcc设置自己的 appid, 或许 qApp->setProperty("_d_appid", "org.deepin.dde.control-center") @zccrs

这个dtkcore提供了一个接口,

@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, zccrs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kegechen kegechen merged commit 8561847 into linuxdeepin:master Mar 1, 2024
18 of 21 checks passed
kegechen pushed a commit to linuxdeepin/dtk6gui that referenced this pull request Mar 5, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#226
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants