Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: StyledBehindWindowBlur crash in render thread #469

Open
wants to merge 0 commits into
base: master
Choose a base branch
from

Conversation

18202781743
Copy link
Contributor

@18202781743 18202781743 commented Feb 27, 2025

as title.

pms: TASK-368399

Summary by Sourcery

Bug Fixes:

  • Fixes a crash in the render thread that could occur when the blur behind item is destroyed by a Loader by checking if the window is valid before rendering.

@18202781743 18202781743 requested review from mhduiy and BLumia February 27, 2025 12:36
deepin-ci-robot added a commit to linuxdeepin/dtk6declarative that referenced this pull request Feb 27, 2025
Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#469
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @18202781743 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • It might be good to add a comment explaining why m_item->window() might be null.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

mhduiy
mhduiy previously approved these changes Feb 27, 2025
@deepin-bot
Copy link
Contributor

deepin-bot bot commented Feb 27, 2025

TAG Bot

New tag: 5.7.11
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #470

@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

当然,我很乐意帮助您审查代码。请提供您想要审查的代码或Git diff输出。

@18202781743 18202781743 requested a review from mhduiy February 28, 2025 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants