Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: from linuxdeepin/dtkgui #97

Merged
merged 1 commit into from
Dec 24, 2024
Merged

sync: from linuxdeepin/dtkgui #97

merged 1 commit into from
Dec 24, 2024

Conversation

deepin-ci-robot
Copy link
Contributor

Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#291

@deepin-ci-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot deepin-ci-robot force-pushed the sync-pr-291-nosync branch 8 times, most recently from 646f93a to c08efaa Compare December 20, 2024 06:55
@deepin-ci-robot
Copy link
Contributor Author

deepin pr auto review

关键摘要:

  • 移除了多个未使用的头文件和宏定义,提高了代码的清晰度和可维护性。
  • 将多个静态函数和宏定义移到了新的头文件中,遵循了单一职责原则。
  • 引入了新的类 DPlatformWindowInterfaceDPlatformWindowInterfaceFactory,简化了窗口接口的实现。
  • 移除了对 DTreeLandPlatformWindowInterfaceDXCBPlatformWindowInterface 的直接依赖,通过工厂模式创建窗口接口实例。
  • 优化了窗口属性设置和获取的逻辑,减少了重复代码。

是否建议立即修改:

  • 是,建议立即修改以保持代码的整洁和可维护性,并确保新引入的接口和工厂模式能够正确工作。

Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#291
@18202781743 18202781743 merged commit 02d4266 into master Dec 24, 2024
11 of 13 checks passed
@18202781743 18202781743 deleted the sync-pr-291-nosync branch December 24, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants