fix: disconnect when object got destroyed

Change-Id: I481837928a379418356c90b267b8e427bf67beef
linuxdeepin · Jan 10, 2019 · 7fe6c1e · 7fe6c1e
1 parent 10e526f
commit 7fe6c1e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/settings.cpp b/src/settings.cpp
@@ -158,11 +158,11 @@ QWidget *Settings::createFontComBoBoxHandle(QObject *obj)
     // init.
     comboBox->setCurrentText(option->value().toString());
 
-    connect(option, &DSettingsOption::valueChanged, [=] (QVariant var) {
+    connect(option, &DSettingsOption::valueChanged, comboBox, [=] (QVariant var) {
         comboBox->setCurrentText(var.toString());
     });
 
-    option->connect(comboBox, &QComboBox::currentTextChanged, [=] (const QString &text) {
+    option->connect(comboBox, &QComboBox::currentTextChanged, option, [=] (const QString &text) {
         option->setValue(text);
     });
 

diff --git a/src/thememodule/themepanel.cpp b/src/thememodule/themepanel.cpp
@@ -103,7 +103,7 @@ void ThemePanel::popup()
     animation->setEndValue(QRect(windowRect.width() - rect.width(), rect.y(), rect.width(), rect.height()));
     animation->start();
 
-    connect(animation, &QPropertyAnimation::valueChanged, [=] { m_themeView->adjustScrollbarMargins(); });
+    connect(animation, &QPropertyAnimation::valueChanged, this, [=] { m_themeView->adjustScrollbarMargins(); });
     connect(animation, &QPropertyAnimation::finished, animation, &QPropertyAnimation::deleteLater);
 }