Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: can not downgrades #302

Merged
merged 1 commit into from
Mar 3, 2025
Merged

fix: can not downgrades #302

merged 1 commit into from
Mar 3, 2025

Conversation

rb-union
Copy link
Contributor

@rb-union rb-union commented Mar 3, 2025

Immutable system has been updated.
When downgrading, need specify --allow-downgrades.

Log: can not downgrades.
Bug: https://pms.uniontech.com/bug-view-305705.html

Immutable system has been updated.
When downgrading, need specify --allow-downgrades.

Log: can not downgrades.
Bug: https://pms.uniontech.com/bug-view-305705.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • installDebThread.cpp中,newImmutableVersion函数的返回值类型应该是bool,但函数名newImmutableVersion可能暗示了返回的是一个新版本号,建议更改为isImmutableVersionNewer或类似的名称以更准确地反映其功能。
  • newImmutableVersion函数中使用了QVersionNumber来比较版本号,但没有处理可能的版本解析错误,例如输入的版本字符串格式不正确时。
  • installDebThread.cpp中的immutableProcess函数中添加了对--allow-downgrades参数的检查,这是一个好的做法,但应该添加注释说明为什么需要这个参数,以及这个参数的引入是否会影响其他依赖项。
  • immutable_process_controller.cpp中的注释// simulate progress, progress = floor(log2(x)) * 10可能需要更正,因为floor(log2(x))的结果可能不是预期的,应该使用qLn函数来计算对数并取整。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lzwind, rb-union

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rb-union rb-union merged commit b5d4301 into linuxdeepin:master Mar 3, 2025
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants