Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typo: PropertiesInterfaceis written incorrectly as WallpaperSlideshow… #2084

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

typo: PropertiesInterfaceis written incorrectly as WallpaperSlideshow… #2084

wants to merge 1 commit into from

Conversation

mhduiy
Copy link
Contributor

@mhduiy mhduiy commented Mar 3, 2025

…Interface

as title

pms: BUG-306041

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 在QDBusConnection::sessionBus().connect调用中，WallpaperSlideshowService的接口从WallpaperSlideshowInterface更改为PropertiesInterface，需要确认这是否符合预期的接口更改。
  • 检查onPropertiesChanged函数是否能够处理新的接口PropertiesInterface，因为接口更改可能会影响函数的参数和调用方式。

是否建议立即修改:

  • 是，需要确保接口更改不会导致运行时错误，并且onPropertiesChanged函数能够正确处理新的接口。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fly602, mhduiy

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fly602 fly602 fly602 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mhduiy @deepin-ci-robot @fly602