Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(busybox): set CONFIG_BASH_IS_ASH #909

Merged
merged 1 commit into from
Dec 30, 2020

Conversation

Thrilleratplay
Copy link
Contributor

enable CONFIG_BASH_IS_ASH

Part of #885 and should be included with #900

@tlaurion
Copy link
Collaborator

tlaurion commented Dec 3, 2020

@Thrilleratplay : impact?

@tlaurion
Copy link
Collaborator

tlaurion commented Dec 3, 2020

https://www.in-ulm.de/~mascheck/various/ash/#busybox :

compile time option ("ASH_BASH_COMPAT", active per default) for several bash compatibility features:
option pipefail, substring and replacement parameter expansion ${x:y:z} and ${x/y/z}, [[, source, $'...', &>

@Thrilleratplay
Copy link
Contributor Author

Thrilleratplay commented Dec 3, 2020

@tlaurion From everything I can determine, no impact. This seems to only creates a symlink from /bin/ash to /bin/bash. CONFIG_ASH_BASH_COMPAT is a different config, providing Bash like comparability in Ash, and is already enabled. It is because CONFIG_ASH_BASH_COMPAT is enabled that CONFIG_BASH_IS_ASH has no impact. Allowing scripts with shebangs #!/bin/bash to be used in initrd scripts and making shellcheck, which does not have ash compatibility, usable. What I cannot determine is how Bash comparable CONFIG_ASH_BASH_COMPAT is or if there are any limitations. It seems to be improving in newer busybox releases and did not have any issues when converting the scripts shebang to bash in #872.

No...this isn't confusing. Why would you say something like that?

@tlaurion
Copy link
Collaborator

tlaurion commented Dec 3, 2020

@Thrilleratplay haha!

@tlaurion tlaurion merged commit 69eb819 into linuxboot:master Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants