Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules/coreboot: set Dasharo coreboot fork rev to the main dasharo branch #1889

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

mkopec
Copy link
Contributor

@mkopec mkopec commented Jan 17, 2025

Here are the changes (mostly irrelevant to Heads) that were merged after #1846:

  • Support for capsule updates (inactive for Heads build)
  • Added NovaCustom MTL dGPU variants
  • EC firmware update in coreboot (inactive for Heads build)

Changes that affect V560TU:

  • Added support for reading power adapter wattage via ACPI
  • Fixes for USB not working
  • Add AC/DC loadline programming, for better stability
  • Fixes for ME disable
  • Fixes for Ethernet detection

I've tested booting into Qubes, ethernet detection, and USB type-A.

tlaurion edit: took #1889 (comment) content

…ranch

Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
@mkopec
Copy link
Contributor Author

mkopec commented Jan 17, 2025

@tlaurion Ideally Dasharo/coreboot#609 shouldve been merged before #1846 , but it went the other way around, so I'm bumping the coreboot rev to what was merged in the end: https://github.com/Dasharo/coreboot/commits/048ca832325d716fcab596822b10f5d493fc2312/

@macpijan
Copy link
Contributor

macpijan commented Jan 17, 2025

Can we explain briefly here in heads upstream MR what has changed since that revision, and which models are affected?
Is there any potential regression, anything to be tested specifically - or what was already tested on your side?

@mkopec
Copy link
Contributor Author

mkopec commented Jan 17, 2025

Mostly changes irrelevant to Heads that were merged in the meantime:

  • Support for capsule updates (inactive for Heads build)
  • Added NovaCustom MTL dGPU variants
  • EC firmware update in coreboot (inactive for Heads build)

Changes that affect V560TU:

  • Added support for reading power adapter wattage via ACPI
  • Fixes for USB not working
  • Add AC/DC loadline programming, for better stability
  • Fixes for ME disable
  • Fixes for Ethernet detection

I've tested booting into Qubes, ethernet detection, and USB type-A.

@tlaurion tlaurion changed the title modules/coreboot: set Dasharo coreboot fork rev to the main dasharo b… modules/coreboot: set Dasharo coreboot fork rev to the main dasharo branch Jan 17, 2025
@tlaurion
Copy link
Collaborator

This is the changeset between pointed commit change
Dasharo/coreboot@94e5f5d...048ca83

@tlaurion
Copy link
Collaborator

tlaurion commented Jan 17, 2025

@mkopec

  • just received v560t replacement. Flashed at 3.3v Found XMC flash chip "XM25QU256C/XM25QU256D" (32768 kB, SPI) on ft2232_spi.
  • tested on nv41 confirmed pr0 works
  • tested on v560tu confirming previous changes changes (functionnaly) and that PRO works (couldn't flash config changes after manually calling lock_chip from recovery shell)
    • boot delays less then 30s after initial flashing to Heads
      • Note that memory training happens twice, once prior of setting system clock, and once after.
      • Note that initial booting time is scary from stock: maybe 3 minutes with an automatic reboot leading to initial ram training
      • Booting time once that is done is ~3 seconds to bootsplash, and from bootsplash to Heads ~7s
    • installing QubesOS works with latest kernel option as per doc for meteor lake
      • Head factory reset works, can boot QubesOS second stage install
        • Second stage install installation of debian-12-xfce seems to take forever but I might be impatient, will see if IO slow later on)
      • Heads can boot final QubesOS install with TPM Disk Unlock Key configured for Default boot option
        • basic functions there including suspend/reume works, network connect, browsing, audio
    • comment on Busybox's fdisk calls fail on >2tb disks #1883 replication on issue with 4tb m2 drive
  • merge in master
  • merge under TESTING NEEDED: STAGING PR (quiet mode + diceware + nk3 fixes) #1875

@tlaurion
Copy link
Collaborator

Something is wrong with second stage QubesOS install, i'm stuck at installing debian-12-xfce template for more than an hour and none of the available terminals provide any interesting output.

Since I can boot into the second stage installer and none of this is related to proposed changes, I'll merge.

@tlaurion tlaurion self-requested a review January 17, 2025 21:37
Copy link
Collaborator

@tlaurion tlaurion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging

@tlaurion tlaurion merged commit 8c3fb03 into linuxboot:master Jan 17, 2025
48 checks passed
@tlaurion
Copy link
Collaborator

Something is wrong with second stage QubesOS install, i'm stuck at installing debian-12-xfce template for more than an hour and none of the available terminals provide any interesting output.

Since I can boot into the second stage installer and none of this is related to proposed changes, I'll merge.

Unfortunately, my nv41 did an "instant reboot" today. I have to revert the changes on master and #1875 @mkopec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants