-
-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
patches/util-linux libusb: patch configure scripts for reproducibility #1321
patches/util-linux libusb: patch configure scripts for reproducibility #1321
Conversation
…de_into_libs=yes -> hardcode_into_libs=no - modules/libusb: remove --disable-tests (not recognized at configure step)
Artifacts for same commit on CircleCI and local build do not show any reproducibility errors for util-linux and libusb. Reminder:
So downloading artifacts of a CircleCI for a specific commit and doing a diffoscope against a local build for same commit id gives good insight of reproducibility issues. Still issues with other modules:
|
@JonathonHall-Purism : please review! |
The only thing I could find on Google matching
How does this affect reproducibility? |
@rbreslow let's show it by comparing x230-htop-maximized tools.cpio from master and this PR.
Basically paths to lib disappear for libblkid.so.1: No change for libusb.... hmmm |
100% agree for this change for libblkid 👍 We should be fine with no RPATH or RUNPATH here since everything will be under /lib. I don't see any rpaths or runpaths in the libusb libs though (nor any other mention of my work tree location), so I think that change is not needed. My libusb build actually did match the one from the x230-hotp-maximized artifacts linked above, maybe libusb is OK as-is @tlaurion ? Do you have differing bins we can take a closer look at?
The only other lib that I see a work tree path in is libjson-c, it's capturing source file paths. Maybe
|
Superseded by #1329 |
All hardcode_into_libs=yes -> hardcode_into_libs=no
Also
Adresses two modules that were not reproducible under linuxboot/heads-wiki#70