modules/hotp-verification: source libusb headers from Makefile DESTDIR #1286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks correct to me 👍 Thanks for fixing this. |
Before, the configure script sourced these from the system FHS (/usr/include/libusb-1.0). The build failed on my NixOS build machine, which doesn't store dependencies in a traditional FHS. And this is the correct approach for reproducible builds.
rbreslow
force-pushed
the
rb/hotp-verification-include-path
branch
from
a3e4a34 to
a5fa2ec
Compare
|
Fixes #640 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the configure script sourced these from the system FHS (
/usr/include/libusb-1.0). The build failed on my NixOS build machine, which doesn't store dependencies in a traditional FHS. And this is the correct approach for reproducible builds.Connects #734
Testing
See: #1282.