fix: Fixes for new pcs and ansible

[tomjelinek]

This makes the role work with the upcoming version of pcs and cluster stack in general.

It also addresses the removal of password_hash filter due to removal of passlib.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.79%. Comparing base (06093e4) to head (7080069).
Report is 18 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #223      +/-   ##
==========================================
+ Coverage   68.50%   76.79%   +8.28%     
==========================================
  Files           3        3              
  Lines         181      181              
  Branches        0       12      +12     
==========================================
+ Hits          124      139      +15     
+ Misses         57       42      -15     

Flag	Coverage Δ
sanity	50.54% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[tomjelinek]

[citest]

[spetrosi]

Thanks for removing dependency for password_hash

[spetrosi]

No need to use cmd parameter here

      command: >-
        openssl passwd
          -6
          -salt {{ ansible_hostname.replace('-', 'x') }}
          {{ ha_cluster_hacluster_password | string }}

[spetrosi]

Ansible supports providing the cmd parameter right with command, if cmd is the only parameter that you need to use.

[tomjelinek]

[citest]

[tomjelinek]

Centos-8 fails with an error that looks like a CI issue to me:

TASK [List packages on the controller to see if OpenSSL is installed] **********
task path: /tmp/collections-1sG/ansible_collections/fedora/linux_system_roles/tests/ha_cluster/tasks/fixture_psks.yml:15
Monday 19 August 2024  06:43:32 -0400 (0:00:00.078)       0:00:02.210 ********* 
[WARNING]: Found "rpm" but Failed to import the required Python library (rpm)
on ip-10-31-46-26.us-east-1.aws.redhat.com's Python /usr/bin/python3.9. Please
read module documentation and install in the appropriate location. If the
required library is installed, but Ansible is using the wrong Python
interpreter, please consult the documentation on ansible_python_interpreter
fatal: [managed_node2 -> localhost]: FAILED! => {
    "changed": false
}

MSG:

Could not detect a supported package manager from the following list: ['rpm', 'apt', 'portage', 'pkg'], or the required Python library is not installed. Check warnings for details.

[spetrosi]

Right, let's ignore this and I will meanwhile look at the failure

[richm]

Suggested change

	password: "{{ __ha_cluster_openssl_call_result.stdout }}"
	password: "{{ __ha_cluster_openssl_call_result.stdout }}"
	no_log: true

[tomjelinek]

I can add no_log, but is it necessary? The password is not shown, the user module hides it even without no_log:

TASK [linux-system-roles.ha_cluster : Set hacluster password] ******************
changed: [localhost] => {
    "append": false,
    "changed": true,
    "comment": "cluster user",
    "group": 189,
    "home": "/var/lib/pacemaker",
    "move_home": false,
    "name": "hacluster",
    "password": "NOT_LOGGING_PASSWORD",
    "shell": "/sbin/nologin",
    "state": "present",
    "uid": 189
}

[tomjelinek]

[citest]

[richm]

The CentOS-Stream-8|ansible-2.9 failures are not related to this PR.