ocp-nvme: remove ocp log page version checking #2527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For supporting ocp 2.5 and legacy version if we want to check the log version, we need to get DSSD(OCP) Spec version from ocp smart. example) Latency Monitor (Log Identifier C3h) OCP 2.0 Log Page version : 0x1 OCP 2.5 Log Page version : 0x4 Signed-off-by: Steven Seungcheol Lee <sc108.lee@samsung.com>
sc108-lee
force-pushed
the
remove_log_ver_checking
branch
from
2396c63
to
b89652d
Compare
|
@arthurshau please have a look. Thanks. |
|
Thanks! |
sc108-lee
added a commit
to sc108-lee/nvme-cli
that referenced
this pull request
Oct 15, 2024
sc108-lee
added a commit
to sc108-lee/nvme-cli
that referenced
this pull request
Oct 15, 2024
Signed-off-by: Steven Seungcheol Lee <sc108.lee@samsung.com>
sc108-lee
added a commit
to sc108-lee/nvme-cli
that referenced
this pull request
Oct 15, 2024
Add missing version update after adding changes for ocp spec 2.5 Signed-off-by: Steven Seungcheol Lee <sc108.lee@samsung.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For supporting ocp 2.5 and legacy version
if we want to check the log version,
we need to get DSSD(OCP) Spec version from ocp smart.
example) Latency Monitor (Log Identifier C3h)
OCP 2.0 Log Page version : 0x1
OCP 2.5 Log Page version : 0x4