-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Add] Transcend plugin command for PLP health #2355
base: master
Are you sure you want to change the base?
Conversation
There are code style issues which need to be addressed. see also the output from checkpatch The rest looks reasonable. Please also use proper commit subject lines, e.g. with the correct prefix. thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update coding style and some errors
Build failed and some other |
- #define PLPRecordPath "PLPRec.txt"
+ #define PLP_RECORD_PATH "PLPRec.txt"
...
- static const int iDis = 20;
+ static const int i_dis = 20;
...
- enum PLPErrorCode {
+ enum plp_error_code { Note: Sorry still not checked detail more so if needed let me comment later. |
Thanks for your reply, I will fix these errors. |
This function will support the Transcend NVMe Devices.
Please feel free to contact me if you have any question.
Thanks.