Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Add] Transcend plugin command for PLP health #2355

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

WBJisMyName
Copy link

This function will support the Transcend NVMe Devices.
Please feel free to contact me if you have any question.
Thanks.

@igaw
Copy link
Collaborator

igaw commented Jun 4, 2024

There are code style issues which need to be addressed. see also the output from checkpatch

The rest looks reasonable.

Please also use proper commit subject lines, e.g. with the correct prefix.

thanks

meson.build Outdated Show resolved Hide resolved
plugins/transcend/transcend-nvme.c Outdated Show resolved Hide resolved
plugins/transcend/transcend-nvme.c Outdated Show resolved Hide resolved
plugins/transcend/transcend-nvme.c Outdated Show resolved Hide resolved
plugins/transcend/transcend-nvme.c Outdated Show resolved Hide resolved
Copy link
Author

@WBJisMyName WBJisMyName left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update coding style and some errors

@WBJisMyName WBJisMyName requested a review from igaw October 21, 2024 07:30
@ikegami-t
Copy link
Contributor

ikegami-t commented Oct 21, 2024

Build failed and some other error errors also detected by the checks.

@ikegami-t
Copy link
Contributor

ikegami-t commented Oct 22, 2024

  1. Looks all commits should be squashed to a patch since no need to separate the patches to fix the first patch.
  2. The commit message should be followed the description below.
    https://github.com/linux-nvme/nvme-cli/pull/2539/files
  3. Seems basically should be confirmed the contribution guide below at first.
    https://github.com/linux-nvme/nvme-cli/blob/master/README.md#how-to-contribute
  4. The camel case definition and variable naming should be fixed as below for example.
- #define PLPRecordPath "PLPRec.txt"
+ #define PLP_RECORD_PATH "PLPRec.txt"
  ...
- static const int iDis = 20;
+ static const int i_dis = 20;
  ...
- enum PLPErrorCode {
+ enum plp_error_code {

Note: Sorry still not checked detail more so if needed let me comment later.

@WBJisMyName
Copy link
Author

Thanks for your reply, I will fix these errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants