Skip to content

Commit

Permalink
wwan: core: Pass string literal as format argument of dev_set_name()
Browse files Browse the repository at this point in the history
Both gcc-14 and clang-18 report that passing a non-string literal as the
format argument of dev_set_name() is potentially insecure.

E.g. clang-18 says:

drivers/net/wwan/wwan_core.c:442:34: warning: format string is not a string literal (potentially insecure) [-Wformat-security]
  442 |         return dev_set_name(&port->dev, buf);
      |                                         ^~~
drivers/net/wwan/wwan_core.c:442:34: note: treat the string as an argument to avoid this
  442 |         return dev_set_name(&port->dev, buf);
      |                                         ^
      |                                         "%s",

It is always the case where the contents of mod is safe to pass as the
format argument. That is, in my understanding, it never contains any
format escape sequences.

But, it seems better to be safe than sorry. And, as a bonus, compiler
output becomes less verbose by addressing this issue as suggested by
clang-18.

Compile tested only.
No functional change intended.

Signed-off-by: Simon Horman <horms@kernel.org>
Signed-off-by: NipaLocal <nipa@local>
  • Loading branch information
horms authored and NipaLocal committed Oct 27, 2024
1 parent d28d4dd commit 6f4d493
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/wwan/wwan_core.c
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,7 @@ static int __wwan_port_dev_assign_name(struct wwan_port *port, const char *fmt)
return -ENFILE;
}

return dev_set_name(&port->dev, buf);
return dev_set_name(&port->dev, "%s", buf);
}

struct wwan_port *wwan_create_port(struct device *parent,
Expand Down

0 comments on commit 6f4d493

Please sign in to comment.