Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use /usr/bin/env sh instead of direct path #1020

Merged
merged 1 commit into from
Sep 27, 2021

Conversation

nathandao
Copy link
Contributor

@nathandao nathandao commented Sep 27, 2021

This ensures the shell scripts work across different UNIX operating system: https://en.wikipedia.org/wiki/Shebang_(Unix)#Program_location

For example, I'm using NixOS and unfortunately sh is not located at /bin/sh

@codecov
Copy link

codecov bot commented Sep 27, 2021

Codecov Report

Merging #1020 (e62ceb1) into master (0ef25e8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1020   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           19        19           
  Lines          641       641           
  Branches       146       146           
=========================================
  Hits           641       641           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ef25e8...e62ceb1. Read the comment docs.

@okonet
Copy link
Collaborator

okonet commented Sep 27, 2021

Thanks for your contribution! Had no idea about it was incorrect :) Tests seem to confirm that too.

@okonet okonet merged commit 3885af8 into lint-staged:master Sep 27, 2021
@nathandao
Copy link
Contributor Author

Thanks @okonet ! : )

@iiroj
Copy link
Member

iiroj commented Sep 27, 2021

The docs tag did not create a release, I think. Could have been a fix. This will be released in the next version.

@okonet
Copy link
Collaborator

okonet commented Sep 28, 2021

I decided for docs since it's only affecting custom configurations afaik.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2021

🎉 This PR is included in version 11.1.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2021

🎉 This PR is included in version 11.2.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2021

🎉 This PR is included in version 11.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@devinrhode2
Copy link

related - same change for husky: typicode/husky#1051

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants