-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
/sys/class/dmi/id/board_name allows identification of librebooted devices. #679
Comments
Hi, I confess that frequent incorporation of workarounds is tiring. In this case I would really prefer Libreboot to fix its stuff. But so be it. Please test and report. |
Works great. With tp_smapi loaded the thinkpad is detected properly. |
Hold on. Here no one gets away without outputs! Show:
|
Sorry! Here's the tlp-stat https://gist.github.com/karstenes/b0a04a0cd609fb980560bdb044cd6a97 |
This output does not fit yet
Stay tuned. |
Done. Please test again and show
Btw: you don't need external kernel modules with your ThinkPad model
Does setting the charge thresholds work with Libreboot? As for force-discharge (recalibration), I expect from your output that with Libreboot it does not work:
You don't need to try external kernel modules, the necessary logic is available from kernel 5.17 on. If it is to work, it must look like this:
|
Here's that gist with that output. |
Output looks fine. Thanks for testing. |
Hi @karstenes : TLP 1.6 Beta 1 is out and contains the change -> #700 |
Is your feature request related to a problem? Please describe.
This will allow proper identification of librebooted thinkpads.
As discussed in this issue, tlp does not identify thinkpads with coreboot due to an improper /sys/class/dmi/id/product_version string. The /sys/class/dmi/id/board_name is properly populated however, which will allow the identification.
Describe the solution you'd like
Utilization of the /sys/class/dmi/id/board_name string for tlp battery driver identification.
Additional context
Here is a gist of all the strings in /sys/class/dmi/id/*
https://gist.github.com/karstenes/c15397843e097bc273bf507a216ef031
The text was updated successfully, but these errors were encountered: