Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/sys/class/dmi/id/board_name allows identification of librebooted devices. #679

Closed
karstenes opened this issue Feb 23, 2023 · 9 comments
Closed

Comments

@karstenes
Copy link

Is your feature request related to a problem? Please describe.

This will allow proper identification of librebooted thinkpads.

As discussed in this issue, tlp does not identify thinkpads with coreboot due to an improper /sys/class/dmi/id/product_version string. The /sys/class/dmi/id/board_name is properly populated however, which will allow the identification.

Describe the solution you'd like

Utilization of the /sys/class/dmi/id/board_name string for tlp battery driver identification.

Additional context
Here is a gist of all the strings in /sys/class/dmi/id/*

https://gist.github.com/karstenes/c15397843e097bc273bf507a216ef031

@linrunner
Copy link
Owner

linrunner commented Feb 24, 2023

Hi,

I confess that frequent incorporation of workarounds is tiring. In this case I would really prefer Libreboot to fix its stuff. But so be it.

Please test and report.

@karstenes
Copy link
Author

Works great. With tp_smapi loaded the thinkpad is detected properly.

@linrunner linrunner reopened this Feb 24, 2023
@linrunner
Copy link
Owner

linrunner commented Feb 24, 2023

Hold on. Here no one gets away without outputs! Show:

sudo tlp-stat -s -b

@karstenes
Copy link
Author

@linrunner
Copy link
Owner

linrunner commented Feb 25, 2023

This output does not fit yet

+++ System Info
System = LENOVO 1.0 ThinkPad T440p

Stay tuned.

@linrunner
Copy link
Owner

Done. Please test again and show

sudo tlp-stat -s -b

Btw: you don't need external kernel modules with your ThinkPad model

  • tp_smapi is for T420 and older only
  • acpi_call is obsolete with kernel 5.17 or newer

Does setting the charge thresholds work with Libreboot?

As for force-discharge (recalibration), I expect from your output that with Libreboot it does not work:

/sys/class/power_supply/BAT0/charge_behaviour = [auto]

You don't need to try external kernel modules, the necessary logic is available from kernel 5.17 on. If it is to work, it must look like this:

/sys/class/power_supply/BAT0/charge_behaviour = [auto] inhibit-charge force-discharge

@karstenes
Copy link
Author

Here's that gist with that output.
https://gist.github.com/karstenes/e440b94d3d244b954c7c65ce71d7587f

@linrunner
Copy link
Owner

Output looks fine. Thanks for testing.

@linrunner
Copy link
Owner

Hi @karstenes : TLP 1.6 Beta 1 is out and contains the change -> #700

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants