Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue #1643 Update nodebalancer_config.md #1644

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

fabkravmaga
Copy link
Contributor

Fix issue #1643 - "region" is not a required argument

📝 Description

What does this PR do and why is this change necessary?

Update document to accurately reflect argument for "linode_nodebalancer_config"

✔️ How to Test

What are the steps to reproduce the issue or verify the changes?

How do I run the relevant unit/integration tests?

Document change, no unit or integration tests needed.

Fix issue linode#1643 - region is not a required argument
@fabkravmaga fabkravmaga requested a review from a team as a code owner November 5, 2024 02:38
@fabkravmaga fabkravmaga requested review from ykim-akamai and ezilber-akamai and removed request for a team November 5, 2024 02:38
Copy link
Contributor

@ezilber-akamai ezilber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@ezilber-akamai ezilber-akamai added the documentation for updates to the documentation in the changelog. label Nov 5, 2024
Copy link
Contributor

@ykim-akamai ykim-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for addressing this

@zliang-akamai zliang-akamai merged commit 3530eda into linode:dev Nov 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation for updates to the documentation in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants