test: Add Cloud Firewall to LKE nodes after integration test execution #1617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ykim-akamai
requested review from
zliang-akamai and
ezilber-akamai
and removed request for
a team
ykim-akamai
added
repo-ci-improvement
ezilber-akamai
approved these changes
Oct 15, 2024
…er_execution' into test/add_e2e_fw_to_lke_nodes_after_execution
lgarber-akamai
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Currently there isn't a CFW being applied to LKE nodes in integration test runs. Attaching FW to LKE cluster upon creation is currently not available which is the reason why only Calico rules were only being applied. This PR fixes that problem by going through the test account after test execution and attaching a default firewall to all remaining instances
✔️ How to Test
Tested on my forked - https://github.com/ykim-1/terraform-provider-linode/actions/runs/11351444139/job/31572142776
📷 Preview
If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.