generated from hashicorp/packer-plugin-scaffolding
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register plug-in as Packer integration #159
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release v1.1.3
Release v1.1.4
Release v1.1.5
Release v1.2.0
nywilken
requested review from
lgarber-akamai and
zliang-akamai
and removed request for
a team
November 22, 2023 16:24
nywilken
commented
Nov 22, 2023
lbajolet-hashicorp
force-pushed
the
dev
branch
from
November 24, 2023 21:16
10c0f61
to
8e737bb
Compare
lbajolet-hashicorp
force-pushed
the
dev
branch
from
November 24, 2023 21:18
8e737bb
to
ebb11fc
Compare
Co-authored-by: Wilken Rivera <dev@wilkenrivera.com>
lgarber-akamai
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the contribution!
zliang-akamai
approved these changes
Nov 29, 2023
zliang-akamai
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 fellow Packer maintainer working on migrating your plugin to the Packer integration framework.
This change takes the necessary steps to register this plugin as an official Packer integration.
Integrations can be found on the Packer integration portal at https://developer.hashicorp.com/packer/integrations.
The pull-request consists of the following changes:
metadata.hcl
for registering the plug-in and it components as integrations.Details on the contents, along with a description of the attributes, can be found at https://github.com/hashicorp/integration-template.
.web-docs
directory for serving the fully render documentation as the integration docs.make build-docs
for syncing changes to thedocs
directory to the.web-docs
directory.Changes to the integration docs can be made at plugin release via the
notify-integration-release-via-tag
workflow ormanually by running the
notify-integration-release-via-manual
workflow.Details on how the Integration framework pipeline works can be found at hashicorp/packer#12702
TODOs
.web-docs/metadata.hcl
.