Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [UIE-6937] - Add the ability to scale up DBaaS #9869

Conversation

grevanak-akamai
Copy link
Contributor

@grevanak-akamai grevanak-akamai commented Nov 3, 2023

Description 📝

Add the ability to scale up DBaaS (e.g. from 4GB to 6GB).

Changes 🔄

  • Add a new tab under DBaaS instance details page(/databases/{engine}/{instance-id} to allow users to scale up DB cluster.
  • In the new tab, show list of available configurations which users can select to scale up.
  • On Selection of new plan and post submission, PUT API request will be made to scale up the configuration.

Preview 📷

Screenshot 2023-11-03 at 4 13 37 PM

Prerequisites

  • Make sure the Databases Scale Up feature flag is on in dev.
  • Make sure you have the necessary customer tag needed to see DBaaS if you had no DBs on your account when it was EOSed.
  • Have an existing or create a new database.

Verification steps

  • Go to your database's details page and select the Scale Up tab (e.g. http://localhost:3000/databases/mysql/1/scale-up)
  • Select any available plan from "Choose a plan" section.
  • Click on "Scale up Database Cluster" button. A confirmation dialog will open. Click on continue.
  • The Scale up request will be processed and once it successful, the page will be taken back to summary tab with the updated configurations displayed.

As an Author I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@grevanak-akamai grevanak-akamai requested a review from a team as a code owner November 3, 2023 11:00
@grevanak-akamai grevanak-akamai requested review from dwiley-akamai and coliu-akamai and removed request for a team November 3, 2023 11:00
@grevanak-akamai grevanak-akamai force-pushed the feature/UIE-6937-dbaas-vertical-scaling branch from 5c4bcf3 to f45a915 Compare November 3, 2023 11:17
@carrillo-erik carrillo-erik self-requested a review November 3, 2023 15:26
@dwiley-akamai dwiley-akamai added the DBaaS Relates to Database as a Service label Nov 6, 2023
Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening up this PR -- I did an initial look-over and left some comments.

The tablet view could use some attention, the formatting gets distorted at certain viewport widths:

Video
Screen.Recording.2023-11-06.at.11.49.48.AM.mov

Also, as the video shows, I don't actually see any plans show up, and there's no region selector anywhere. This is an Atlanta database.

Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't able to actually complete a scale up, is that because the back-end code supporting these changes hasn't been merged to prod yet?

Screenshots

Screenshot 2023-11-13 at 10 59 55 AM

Screenshot 2023-11-13 at 11 00 06 AM

@grevanak-akamai
Copy link
Contributor Author

I wasn't able to actually complete a scale up, is that because the back-end code supporting these changes hasn't been merged to prod yet?

Screenshots

That might have been the case. You can try it now in dev environment.

@bnussman-akamai
Copy link
Member

Just wanted to give a heads up that this PR won’t make it into Cloud Manager’s Monday (1/8/2024) production release. We’ll keep working to get the PR in a mergeable state so that it can be included in the following release (1/22).

Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making suggested chances. Ui looks good to me but there's a few things to clean up (see comments).

Also - you have invalid html in your tab
Screenshot 2024-01-08 at 09 38 00
Screenshot 2024-01-08 at 09 38 27


Did you vet the copy with products? this reads a little odd
Screenshot 2024-01-08 at 09 39 01

@bnussman-akamai
Copy link
Member

PR is looking solid on my end! Is there any reason not to turn the feature on in production now so we can test this PR against the production environment?

@grevanak-akamai
Copy link
Contributor Author

grevanak-akamai commented Jan 9, 2024

@bnussman-akamai - There were API changes required for this feature due to which we thought of introducing feature flag. I don't have an update yet whether those changes are available in production environment. If the changes are ready, then we can test in production environment as well. I hope that shouldn't be a blocker to merge this PR.

Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the changes!

This is good to go as far I am concerned

  • UI is consistent with Cloud Manager and responsive ✅
  • Code looks good ✅
  • Feature works as expected in DEV environment ✅

@grevanak-akamai Please let the team know in our channel when you plan on turning this on in Production so we can test things locally before doing so.

@bnussman-akamai
Copy link
Member

Providing my final review right now 👀

You can expect this to be included in our next release (1/22/2024)

Copy link
Member

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen.Recording.2024-01-10.at.12.33.16.PM.mov

@bnussman-akamai bnussman-akamai added the Approved Multiple approvals and ready to merge! label Jan 10, 2024
@bnussman-akamai bnussman-akamai merged commit 14e6d00 into linode:develop Jan 11, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! DBaaS Relates to Database as a Service Ready for Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants