Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [M3-7028] - Add AGLB Edit Route Drawer #9822

Merged
merged 16 commits into from
Oct 24, 2023

Conversation

jaalah-akamai
Copy link
Contributor

Description 📝

Implements the AGLB edit route drawer.

Preview 📷

edit-route.mp4

How to test 🧪

Prerequisites

  • Checkout this PR
  • Turn on the MSW (bottom left dev tools)

Reproduction steps

Verification steps

  • Observe drawer opens with:
    • Title containing specific route label
    • Input field containing current route label
    • Current protocol selected
  • Observe when click Edit Route network payload should contain your new options
  • Run cypress tests yarn cy:run -s cypress/e2e/core/loadBalancers/load-balancer-routes.spec.ts

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@jaalah-akamai jaalah-akamai added Ready for Review ACLB Relating to the Akamai Cloud Load Balancer labels Oct 20, 2023
@jaalah-akamai jaalah-akamai self-assigned this Oct 20, 2023
@jaalah-akamai jaalah-akamai requested a review from a team as a code owner October 20, 2023 02:58
@jaalah-akamai jaalah-akamai requested review from carrillo-erik and cpathipa and removed request for a team October 20, 2023 02:58
Copy link
Contributor

@cpathipa cpathipa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Observe drawer opens
  • Title containing specific route label
  • Input field containing current route label
  • Current protocol selected
  • Observe when click Edit Route network payload should contain your new options
  • Run cypress tests yarn cy:run -s cypress/e2e/core/loadBalancers/load-balancer-routes.spec.ts

Confirming on the above validation tasks and I haven't seen any regression. I agree with @bnussman-akamai feedback.

Questions:
I have noticed that other places of edit scenarios I feel like language for the primary button is inconsistent. "Save Changes" make sense to me.

Edit Route Edit Volume
image image

@jaalah-akamai
Copy link
Contributor Author

I have noticed that other places of edit scenarios I feel like language for the primary button is inconsistent. "Save Changes" make sense to me.

I've also noticed inconsistency of whether we include data next to the title or not (ie: Edit Route: <route_label> ... in addition, some designs have a dash instead of a colon 🤔 ). @bnussman-akamai did you want me to reach out to UX or did you want to make a judgment call?

@bnussman-akamai
Copy link
Member

I think we should do what is most common in Cloud Manager. I think that would be Edit Route <route label>. So without the : @jaalah-akamai

@jaalah-akamai
Copy link
Contributor Author

I think we should do what is most common in Cloud Manager. I think that would be Edit Route . So without the : @jaalah-akamai

Looking good now 👍

@bnussman-akamai bnussman-akamai added Add'tl Approval Needed Waiting on another approval! and removed Ready for Review labels Oct 23, 2023
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed routes update as expected and editing a route to be labelless is no longer possible. 🚢

@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Oct 24, 2023
@bnussman-akamai bnussman-akamai merged commit 8b65300 into linode:develop Oct 24, 2023
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ACLB Relating to the Akamai Cloud Load Balancer Approved Multiple approvals and ready to merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants