-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [M3-7028] - Add AGLB Edit Route Drawer #9822
Conversation
packages/manager/src/features/LoadBalancers/LoadBalancerDetail/LoadBalancerRoutes.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/LoadBalancers/LoadBalancerDetail/Routes/EditRouteDrawer.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/LoadBalancers/LoadBalancerDetail/Routes/RuleDrawer.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/LoadBalancers/LoadBalancerDetail/Routes/EditRouteDrawer.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/LoadBalancers/LoadBalancerDetail/Routes/EditRouteDrawer.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/LoadBalancers/LoadBalancerDetail/Routes/EditRouteDrawer.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/LoadBalancers/LoadBalancerDetail/Routes/RuleDrawer.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Observe drawer opens
- Title containing specific route label
- Input field containing current route label
- Current protocol selected
- Observe when click Edit Route network payload should contain your new options
- Run cypress tests yarn cy:run -s cypress/e2e/core/loadBalancers/load-balancer-routes.spec.ts
Confirming on the above validation tasks and I haven't seen any regression. I agree with @bnussman-akamai feedback.
Questions:
I have noticed that other places of edit scenarios I feel like language for the primary button is inconsistent. "Save Changes" make sense to me.
Edit Route | Edit Volume |
---|---|
I've also noticed inconsistency of whether we include data next to the title or not (ie: |
I think we should do what is most common in Cloud Manager. I think that would be |
Looking good now 👍 |
packages/manager/cypress/e2e/core/loadBalancers/load-balancer-routes.spec.ts
Outdated
Show resolved
Hide resolved
packages/manager/src/features/LoadBalancers/LoadBalancerDetail/Routes/EditRouteDrawer.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed routes update as expected and editing a route to be labelless is no longer possible. 🚢
Description 📝
Implements the AGLB edit route drawer.
Preview 📷
edit-route.mp4
How to test 🧪
Prerequisites
Reproduction steps
...
next to a routeEdit
buttonVerification steps
Edit Route
network payload should contain your new optionsyarn cy:run -s cypress/e2e/core/loadBalancers/load-balancer-routes.spec.ts
As an Author I have considered 🤔
Check all that apply