Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [UIE-6952] - DBaaS menu flickers on page load #9808

Conversation

corya-akamai
Copy link
Contributor

Description 📝

Fix the Dbaas menu flickering on page load when waiting for API call.

Changes 🔄

  • Wait for API call to finish before checking for error.

How to test 🧪

Prerequisites

(How to setup test environment)

  • User with restricted access - no billing access

Reproduction steps

  • Login in as restricted user
  • Refresh page and see the Dbaas menu appear then disappear on user interaction

Verification steps

(How to verify changes)

  • Menu does not appear for restricted user during page load

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@corya-akamai corya-akamai requested a review from a team as a code owner October 17, 2023 19:39
@corya-akamai corya-akamai requested review from bnussman-akamai and abailly-akamai and removed request for a team October 17, 2023 19:39
@bnussman-akamai bnussman-akamai changed the title fix [UIE-6952]: dbaas menu flickers on page load fix: [UIE-6952] - DBaaS menu flickers on page load Oct 18, 2023
@bnussman-akamai bnussman-akamai added the DBaaS Relates to Database as a Service label Oct 18, 2023
Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't really reproduce this issue but the fix isn't going to hurt either 👍

Also, added a changeset

@bnussman-akamai bnussman-akamai merged commit 3df9d02 into linode:develop Oct 19, 2023
12 of 13 checks passed
@corya-akamai corya-akamai deleted the feature/UIE-6952-fix-dbaas-menu-flickers-on-page-load branch July 31, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DBaaS Relates to Database as a Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants