Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: [M3-6219] - Clean up Cypress Firewall tests #9807

Merged

Conversation

jdamore-linode
Copy link
Contributor

Description 📝

This cleans up the Cypress Firewall tests by implementing newer testing patterns.

Changes 🔄

  • Remove calls to cy.intercept, replacing them with calls intercept and mocking utils
  • Use ui helpers where applicable, reduce number of calls to cy.get()
  • Adds a couple assertions related to migration warnings shown to and accepted by the user

How to test 🧪

Prerequisites

yarn && yarn build && yarn start:manager:ci

Test Command

yarn cy:run -s "cypress/e2e/core/firewalls/create-firewall.spec.ts,cypress/e2e/core/firewalls/delete-firewall.spec.ts,cypress/e2e/core/firewalls/migrate-linode-with-firewall.spec.ts,cypress/e2e/core/firewalls/update-firewall.spec.ts"

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@jdamore-linode jdamore-linode requested a review from a team as a code owner October 17, 2023 19:25
@jdamore-linode jdamore-linode requested review from hana-akamai and tyler-akamai and removed request for a team October 17, 2023 19:25
@jdamore-linode jdamore-linode self-assigned this Oct 17, 2023
Copy link
Contributor

@hana-akamai hana-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that E2E tests passed locally ✅

@hana-akamai hana-akamai added Add'tl Approval Needed Waiting on another approval! and removed Ready for Review labels Oct 17, 2023
@tyler-akamai
Copy link
Contributor

Confirmed, all tests passed!

Screenshot 2023-10-18 at 10 07 38 AM

@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Oct 18, 2023
@jdamore-linode jdamore-linode merged commit f25f849 into linode:develop Oct 25, 2023
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants