-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [M3-7270] - Edit Linode VLAN config interface #9798
fix: [M3-7270] - Edit Linode VLAN config interface #9798
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks @hana-linode! Confirmed that the tests are passing and that the config dialog is working as expected
Since this is a bug from a recent story that hasn't released yet, I don't think this needs a changeset |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 awesome thanks Hana!
✅ confirmed that config dialog works as expected with vlans
✅ confirmed that tests pass
## Description 📝 Bug from linode#9709 On the prod env, we were unable to edit a config due to the config interface being deleted. This was due to the `regionHasVPCs` variable being coupled with `regionHasVLANS` in the if statement to delete config interfaces. The fix was to handle VPCs and VLANs separately. ## How to test 🧪 ### Prerequisites - Point to the prod environment ### Reproduction steps - Go to a Linode's details page and click on the `Configurations` tab - Click the edit button and scroll down to the Networking section - Select a VLAN and save changes ### Verification steps - The VLAN changes should be reflected in the Configurations table
Description 📝
Bug from #9709
On the prod env, we were unable to edit a config due to the config interface being deleted. This was due to the
regionHasVPCs
variable being coupled withregionHasVLANS
in the if statement to delete config interfaces. The fix was to handle VPCs and VLANs separately.Note: Linode details have been obfuscated
Preview 📷
before.mov
after.mov
How to test 🧪
Prerequisites
Reproduction steps
Configurations
tabVerification steps