Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [M3-7243] - Add 'Tests' to Changeset types #9766

Merged
merged 2 commits into from
Oct 6, 2023

Conversation

coliu-akamai
Copy link
Contributor

@coliu-akamai coliu-akamai commented Oct 5, 2023

Description 📝

Add 'Tests' to Changeset types as per frontend cafe discussion and updated relevant docs

Preview 📷

image

How to test 🧪

Run yarn changeset and confirm Tests is listed under the changeset types to select from. Create a changeset of that type, don't commit it, and run yarn generate-changelogs to confirm a changelog is generated with a 'Tests' section.

@coliu-akamai coliu-akamai self-assigned this Oct 5, 2023
@coliu-akamai coliu-akamai marked this pull request as ready for review October 5, 2023 21:13
@coliu-akamai coliu-akamai requested a review from a team as a code owner October 5, 2023 21:13
@coliu-akamai coliu-akamai requested review from bnussman-akamai, abailly-akamai and jdamore-linode and removed request for a team October 5, 2023 21:13
@coliu-akamai coliu-akamai changed the title chore: [M3-7243] - Add 'Tested' to Changeset types chore: [M3-7243] - Add 'Tests' to Changeset types Oct 5, 2023
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just saw this. 😉 Thank you!

Screenshot 2023-10-05 at 2 29 59 PM
Screenshot 2023-10-05 at 2 31 18 PM

@coliu-akamai coliu-akamai added the Add'tl Approval Needed Waiting on another approval! label Oct 5, 2023
@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Oct 6, 2023
Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you! 🚢

@coliu-akamai coliu-akamai merged commit 5a07117 into linode:develop Oct 6, 2023
13 checks passed
@coliu-akamai coliu-akamai deleted the chore-m3-7243 branch October 6, 2023 20:12
@coliu-akamai coliu-akamai restored the chore-m3-7243 branch October 6, 2023 20:12
@coliu-akamai coliu-akamai deleted the chore-m3-7243 branch October 6, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants