-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [M3-7157] - Only show IPv4s specific to a linode-subnet relationship on VPC details page #9710
feat: [M3-7157] - Only show IPv4s specific to a linode-subnet relationship on VPC details page #9710
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logic looks good. From the mocking I tried, I saw the correct VPC IP!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correct IP showing as expected in the UI ✅
Approving pending additional coverage. thx!
} | ||
} | ||
|
||
return undefined; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move this to a .utils.ts and get it tested with a factory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed the correct IP and that the existing unit test still passes 🔨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The VPC IPv4 displayed matches the IPv4 address expected ✅
Unit tests pass ✅
thanks everyone! merging this PR as the integration test failure is unrelated to VPC changes |
Description 📝
Ensure that a linode row inside the subnets table only shows the IP specific to that subnet
Major Changes 🔄
Add subnetId to SubnetLinodeRow props, and find the interface associated with that specific subnet
Preview 📷
MSW example:
How to test 🧪
How to verify changes?
packages/manager/src/factories/linodeConfigInterfaceFactory.ts
line 28 and try to put in specific subnet_ids. If the mock subnet_id matches, the IPs will show up (see MSW screenshot example)packages/manager/src/features/VPCs/VPCDetail/SubnetLinodeRow.tsx
, and check the interfaces in the configs. The interface with the corresponding subnetId should have the same IPv4 as the one appearing in the row)How to run Unit or E2E tests?
yarn test SubnetLinodeRow
(existing test should still pass)yarn test 'packages/manager/src/features/VPCs/utils.test.ts'