Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [UIE-6886] - Update event name for dbaas_low_disk_space #9678

Merged
merged 4 commits into from
Sep 14, 2023
Merged

fix: [UIE-6886] - Update event name for dbaas_low_disk_space #9678

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2548bdf
fix [UIE-6886] dbaas_low_disk_space event name
corya-akamai Sep 14, 2023
139369b
Added changeset: Renamed event from database_low_disk_space_remaining…
corya-akamai Sep 14, 2023
6613c5b
Added changeset: Renamed event from database_low_disk_space_remaining…
corya-akamai Sep 14, 2023
401adb1
remove change set
corya-akamai Sep 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/api-v4/src/account/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ export type EventAction =
| 'community_mention'
| 'community_question_reply'
| 'credit_card_updated'
| 'database_low_disk_space_remaining'
| 'database_low_disk_space'
| 'database_backup_restore'
| 'database_create'
| 'database_credentials_reset'
Expand Down
5 changes: 2 additions & 3 deletions packages/manager/src/features/Events/eventMessageGenerator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,11 +101,10 @@ export const eventMessageCreators: { [index: string]: CreatorsForStatus } = {
database_delete: {
notification: (e) => `Database ${e.entity!.label} has been deleted.`,
},
database_low_disk_space_remaining: {
database_low_disk_space: {
finished: (e) =>
`Low disk space alert for database ${e.entity!.label} has cleared.`,
notification: (e) =>
`Database ${e.entity!.label} has low disk space remaining.`,
notification: (e) => `Database ${e.entity!.label} has low disk space.`,
},
database_update: {
finished: (e) => `Database ${e.entity!.label} has been updated.`,
Expand Down
2 changes: 1 addition & 1 deletion packages/manager/src/mocks/serverHandlers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1111,7 +1111,7 @@ export const handlers = [
percent_complete: 15,
});
const dbEvents = eventFactory.buildList(1, {
action: 'database_low_disk_space_remaining',
action: 'database_low_disk_space',
entity: { id: 999, label: 'database-1', type: 'database' },
message: 'Low disk space.',
});
Expand Down