feat: [M3-7108] - Add AGLB Configuration Delete Dialog #9675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked spelling, styles, and functionality on the dialog and everything looks good. My single reservation is around the usage of a |
carrillo-erik
approved these changes
Sep 14, 2023
| open={open} | ||
| title={`Delete Configuration ${configuration.label}?`} | ||
| > | ||
| Are you sure you want to delete this configuration? |
There was a problem hiding this comment.
Should this string be wrapped in a Typography component?
There was a problem hiding this comment.
I see no visual difference when using a Typography. I think we don't need to use one anymore 🎉
cpathipa
approved these changes
Sep 14, 2023
This was referenced Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Preview 📷
How to test 🧪
http://localhost:3000/loadbalancers/0/configurations