Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [M3-6950] - Restored longview active table rows and arrow #9643

Merged
merged 3 commits into from
Sep 7, 2023

Conversation

jaalah-akamai
Copy link
Contributor

Description 📝

There was an issue on the longview processes table where the entire row was not highlighted, and the arrow was not in the correct place. This is important because the data to the right of the table is contingent on the selected row.

Major Changes 🔄

  • We needed selected={selected} passed to the styled component
  • Removed unnecessary styled components for the arrow
  • Simplified how we create the css arrow

Preview 📷

Before After
Screenshot 2023-09-07 at 12 09 34 PM Screenshot 2023-09-07 at 11 59 28 AM
longview.mp4

How to test 🧪

  1. Create a new Linode (I used Debian 11)
  2. Create a new Longview client
  3. Copy the installation curl command
  4. SSH into your Linode and paste the installation command
  5. Note: I had start the longview service with systemctl: sudo systemctl start longview following https://www.linode.com/docs/products/tools/longview/guides/troubleshooting/
  6. Go to /longview/clients/{ID}/processes
  7. Ensure that the row is properly highlighted
  8. Ensure that an arrow appears to the right of the row (outside of the actual row itself)

@jaalah-akamai jaalah-akamai added the Bug Fixes for regressions or bugs label Sep 7, 2023
@jaalah-akamai jaalah-akamai self-assigned this Sep 7, 2023
Copy link
Member

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in both light and dark mode!

@jaalah-akamai jaalah-akamai added the Add'tl Approval Needed Waiting on another approval! label Sep 7, 2023
@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! Ready for Review labels Sep 7, 2023
Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 looks awesome!

@jaalah-akamai jaalah-akamai merged commit b919af7 into linode:develop Sep 7, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Bug Fixes for regressions or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants