Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change: [M3-7077] - Remove VPC column from Linodes landing page table #9625

Merged
merged 2 commits into from
Sep 1, 2023
Merged

change: [M3-7077] - Remove VPC column from Linodes landing page table #9625

merged 2 commits into from
Sep 1, 2023

Conversation

coliu-akamai
Copy link
Contributor

@coliu-akamai coliu-akamai commented Sep 1, 2023 •
edited
Loading

Description 📝

** Kept logic for:

  • Kept the validation/api changes from that PR, as those changes still reflect the API
  • Keeping IP address label as 'Public IP address'
  • kept the factories for linode configs as well, in case those are useful later down the road

Major Changes 🔄

  • removed VPC column related logic from LinodeRow.tsx and updated tests
Before After
image image

How to test 🧪

  1. Navigate to Linode landing page and confirm that VPC column is gone, even if the VPC feature flag is active; confirm that there are no queries to GET linode/instances/{linodeID}/configs

@coliu-akamai coliu-akamai added the VPC Relating to VPC project label Sep 1, 2023
@coliu-akamai coliu-akamai self-assigned this Sep 1, 2023
@coliu-akamai coliu-akamai mentioned this pull request Sep 1, 2023
Merged
hana-akamai
hana-akamai approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@hana-akamai hana-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

dwiley-akamai
dwiley-akamai approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@coliu-akamai coliu-akamai merged commit 4f1b8c9 into linode:develop Sep 1, 2023
11 checks passed
corya-akamai pushed a commit to corya-akamai/manager that referenced this pull request Sep 6, 2023
@coliu-akamai @corya-akamai
change: [M3-7077] - Remove VPC column from Linodes landing page table (…
edcca2c 
…linode#9625)

* remove VPC column from linode landing table and update tests

* Added changeset: Removed VPC column from Linodes landing page table
abailly-akamai pushed a commit that referenced this pull request Sep 7, 2023
@coliu-akamai @abailly-akamai
change: [M3-7077] - Remove VPC column from Linodes landing page table (…
71bad5e 
…#9625)

* remove VPC column from linode landing table and update tests

* Added changeset: Removed VPC column from Linodes landing page table
This was referenced Sep 15, 2023
Merged
Merged
@coliu-akamai coliu-akamai deleted the m3-7077 branch September 26, 2023 19:09
@coliu-akamai coliu-akamai mentioned this pull request Oct 18, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwiley-akamai dwiley-akamai dwiley-akamai approved these changes

@hana-akamai hana-akamai hana-akamai approved these changes

@bnussman-akamai bnussman-akamai Awaiting requested review from bnussman-akamai

Assignees

@coliu-akamai coliu-akamai

Labels
Ready for Review VPC Relating to VPC project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coliu-akamai @dwiley-akamai @hana-akamai