Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [M3-7029] - Add AGLB Certificate Create Drawer #9616

Conversation

bnussman-akamai
Copy link
Member

@bnussman-akamai bnussman-akamai commented Aug 31, 2023

Description πŸ“

  • Adds Create Certificate Drawer ✨

Preview πŸ“·

Screenshot 2023-08-31 at 2 34 38 PM

How to test πŸ§ͺ

  • Go to http://localhost:3000/loadbalancers/1/certificates with the MSW on and try to upload a certificate (you can use fake values)
  • Nothing will really happen when you submit the form successfully because of the inherent nature of React Query and the MSW
  • Check client side validation

@bnussman-akamai bnussman-akamai added the ACLB Relating to the Akamai Cloud Load Balancer label Aug 31, 2023
@bnussman-akamai bnussman-akamai self-assigned this Aug 31, 2023
Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘ looks great!

@bnussman-akamai bnussman-akamai added Add'tl Approval Needed Waiting on another approval! and removed Ready for Review labels Sep 1, 2023
Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great πŸ‘

Is there any type of additional validation we should run on those fields? Not sure if there's an expected shape for either

<TextField
errorText={errorMap.certificate}
label="TLS Certificate"
labelTooltipText="TODO"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just making sure we have this tracked to complete in the future?

@jaalah-akamai jaalah-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Sep 7, 2023
@bnussman-akamai bnussman-akamai merged commit 69a4d5b into linode:develop Sep 8, 2023
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ACLB Relating to the Akamai Cloud Load Balancer Approved Multiple approvals and ready to merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants