fix: [M3-6999] - Remove Docker Compose hardcoded container names #9524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rdcoded 'web' port
bnussman-akamai
approved these changes
Aug 9, 2023
bnussman-akamai
added
Add'tl Approval Needed
abailly-akamai
approved these changes
Aug 11, 2023
bnussman-akamai
added
Approved
corya-akamai
pushed a commit
to corya-akamai/manager
that referenced
this pull request
Sep 6, 2023
…rdcoded 'web' port (linode#9524)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
This PR attempts to resolve the Jenkins E2E test instability we've seen caused by conflicts related to the
webservice and its name.There is a corresponding internal PR which modifies the pipeline to take these changes into account. Both PRs will need to be merged at the same time to limit test breakage. Additionally, existing branches will need to pull in the latest changes from
developto avoid breakage.Major Changes 🔄
webservice hardcoded port and container name so that multiple containers serving Cloud Manager can run simultaneously on a single hoste2e-1,e2e-2, etc. services into a singlee2eserviceHow to test 🧪
This isn't easily testable, but I will abort the automatic test run that kicks off against this PR and re-run it with the pipeline changes in place to demonstrate that the pipeline works as expected.