feat: [M3-6723] – VPC Subnet endpoints, validation, & React Query queries #9390
Conversation
dwiley-akamai
added
@linode/api-v4
bnussman-akamai
added
Ready for Review
Missing Changeset
and removed
Missing Changeset
labels
| ); | ||
| }; | ||
|
|
||
| export const useCreateSubnetMutation = (vpcID: number) => { |
There was a problem hiding this comment.
The invalidation in the onSuccess functions for useCreateSubnetMutation, useUpdateSubnetMutation, and useDeleteSubnetMutation can probably be streamlined/improved, but I'd rather optimize those later in the process in tickets where those queries are made use of as opposed to over-optimizing at this early stage.
packages/manager/src/App.tsx
Outdated
| @@ -58,6 +59,9 @@ const BaseApp = withFeatureFlagProvider( | |||
|
|
|||
| const { enqueueSnackbar } = useSnackbar(); | |||
|
|
|||
| // const { data: subnetData } = useSubnetQuery(vpcID, subnetID); | |||
| // console.log(subnetData); | |||
There was a problem hiding this comment.
Like last time, all of the changes in this file are temporary for testing purposes and will be removed prior to merging.
You can uncomment out the lines and replace vpcID and subnetID with real IDs to check the data is coming through.
| /[a-zA-Z0-9-]+/, | ||
| 'Must include only ASCII letters, numbers, and dashes' | ||
| ), | ||
| .matches(/[a-zA-Z0-9-]+/, LABEL_REQUIREMENTS), |
There was a problem hiding this comment.
Since the label validation is essentially the same for all the schemas, what do you think about re-using that? const labelValidation = ... then wherever it's used we can tack on .required(...) or .notRequired(...)?
There was a problem hiding this comment.
Can we also confirm that the regex we're using is sufficient? I think we may need to be more strict by doing /^[a-zA-Z0-9-]+$/.
There was a problem hiding this comment.
In the cases of "test ", " test ", and " test" I checked to see if the current VLAN validation would catch those and it did, so I think what we have currently should be sufficient
2 flaky tests on run #4858 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| update firewall > updates a firewall's linodes and rules |
Output
Screenshots
Video
|
|
linodes/smoke-linode-landing-table.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| linode landing actions > deleting multiple linodes with action menu |
Output
Screenshots
Video
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
bnussman-akamai
added
Add'tl Approval Needed
bnussman-akamai
added
Approved
Description 📝
Add initial VPC subnet endpoints, validation, and RQ queries.
Major Changes 🔄
createSubnetSchemaandmodifySubnetSchemafor validation, plus a few constants and a utility function for testing IP validityHow to test 🧪
Reach out for detailed testing instructions if you want to work with the queries in alpha.