feat: [M3-6789] - Improve failed backup error messaging

[mjac0bs]

Description 📝

Error messaging for the backups service is minimal and does not provide users with much insight on the reason for a failure or whether they can address it.

Ultimately, we want to display more detailed error messages in Cloud Manager for failed backup restores and snapshot backups, which will require API to return these errors for Cloud to surface. This is ticketed and in the backlog: ARB-4001.

In the meantime, this PR addresses front-end improvements we can make to error messaging with the goal of (a) error prevention and (b) providing additional general context of limitations and requirements for the backup service.

We are updating generic error messages with a docs link to point users to potential reasons for the failure. We are also adding a warning notice in the linode create page to help prevent customers from encountering backup service failures due to unsupported disks being present in their configuration, which is a common reason backup restores fail.

Note: When testing, you may notice a bug where failed snapshot backups are returning incorrect finished timestamps (e.g. 2 seconds ago when the failure was 5 minutes ago). This is a known and ticketed API bug due to the way duration continues to accumulate for linode_snapshot events when the event is finished/failed. We're seeing it now due to recent changes (#9215) to update the timestamp for finished events, rather than use the created timestamp.

TODO - Address UX feedback:

• Fix the link color in dark mode on error toasts.

Major Changes 🔄

• Updates notification menu/activity feed events for backups_restore and linode_snapshot failure events include link to doc.
• Updates error toasts for backups_restore and linode_snapshot failures to make them persistent, link to doc, and match the copy in the event failure message for consistency.
• Displays a warning notice above the backups section when a user enables Backups as an Add-on when creating or cloning a new linode with a custom image.
• Fixes a styling bug where the error notice on the Manual Snapshot section was displaying inline with textfield, rather than above.

Preview 📷

Before	After	Description
		linode_snapshot error toast for failed manual snapshot backup
		linode_snapshot event message for failed manual snapshot backup
		backups_restore event message for failure
		added backups_restore error toast for failure
		warning notice for enabled Backups Add-on when creating with custom image
		fixed styling regression for error notice in Manual Backups section

How to test 🧪

1. How to setup test environment?
2. How to reproduce the issue (if applicable)?
   1. Repeat steps below in 'How to verify changes' in prod and note that generic error messaging, non-persistent error toasts, and lack of warning about incompatible filesystems when enabling the backup service.
3. How to verify changes?
   1. Create a Linode that backups will fail for. One way to do this is to create a Linode from an Image that is not a valid filesystem. Reach out to me for the test account that has a Linode with a bad image set up already or follow the steps below to create your own.
      1. Go to http://localhost:3000/images/create/upload and upload an image that is not in ext3 or ext4 format. For the purposes of testing, this can be a zipped text file containing anything. Call the image label bad-image or something similar.
   2. Once the bad-image has uploaded, go to http://localhost:3000/linodes/create?type=Images and select bad-image in the image dropdown. Fill in the necessary fields and then click the Backups checkbox to enable backups.
      1. Confirm that, only when the Backups add-on is checked, a warning notice appears informing the user of the file system limitations of backups when using custom images.
      2. Create the new linode (e.g. bad-image-us-west) from the bad image.
   3. Navigate to the Linode Details > Backups page and try to create a new manual snapshot backup.
      4. Quickly, while that backup is in progress, try to take another snapshot. Observe the error notice is displayed above the text field, fixing a regression in prod.
      5. When the snapshot backup fails (which it will, because our image is bad), confirm the error toast and event message with updated copy appear. If you want to test the error messaging for backups_restore, we can mock the event by adding to the MSW events endpoint:

    const failedBackupRestoreEvent = eventFactory.build({
      action: 'backups_restore',
      status: 'failed',
      percent_complete: 100,
    });

4. Verify that the warning notice for compatible filesystems when enabling Backups also appears in the Clone create flow and not on the Distro create flow.
   1. Go to http://localhost:3000/linodes/create?type=Clone%20Linode and select your linode with a public image and enable backups; confirm no warning message. Select linode with a bad image and enable backups; confirm warning message. Go to http://localhost:3000/linodes/create?type=distro, select an image, and also confirm no warning message.

[cypress]

1 flaky tests on run #4793 ↗︎

0

177

3

0

1

Details:

Fix toast link text color in dark mode
Project: Cloud Manager E2E	Commit: 9ac5fb2180
Status: Passed	Duration: 13:48 💡
Started: Jul 6, 2023 10:14 PM	Ended: Jul 6, 2023 10:28 PM

  cypress/e2e/core/linodes/smoke-linode-landing-table.spec.ts • 1 flaky test

View Output Video

Test		Artifacts
linode landing actions > deleting multiple linodes with action menu		Output Screenshots Video

_{This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.}

[hkhalil-akamai]

This is an excellent UX improvement. Left some suggestions, but the PR looks good from my testing.