Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M3-6068: Incorrect tab selection on Linode Create #8717

Conversation

cpathipa
Copy link
Contributor

@cpathipa cpathipa commented Jan 12, 2023

Description 📝

Sets plan tab to "Dedicated"

Preview 📷

image

Remove this section or include a screenshot or screen recording of the change

How to test 🧪

Navigate to create linode
Validate the plan tab is set to default if no plan is selected.

@cpathipa cpathipa changed the title set Dedicated plan tas as default M3-6068: Incorrect tab selection on Linode Create Jan 12, 2023
@cpathipa cpathipa self-assigned this Jan 12, 2023
@cpathipa cpathipa added the Bug Fixes for regressions or bugs label Jan 13, 2023
Copy link
Contributor

@jcallahan-akamai jcallahan-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should be made in SelectPlanQuantityPanel too, so that the change is reflected on the Create Kubernetes page as well. Otherwise LGTM.

@cpathipa
Copy link
Contributor Author

SelectPlanQuantityPanel

Thank you @jcallahan-akamai for guiding on this, I wasn't aware of this screen. Updated SelectPlanQuantityPanel as well.

image

dwiley-akamai
dwiley-akamai previously approved these changes Jan 13, 2023
Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚢

Let's point the base branch to staging instead of develop

@CodyFinn-Akamai CodyFinn-Akamai changed the base branch from develop to staging January 13, 2023 16:08
@CodyFinn-Akamai CodyFinn-Akamai dismissed stale reviews from dwiley-akamai, bnussman-akamai, and mjac0bs January 13, 2023 16:08

The base branch was changed.

@cpathipa cpathipa changed the base branch from staging to develop January 13, 2023 17:50
@cpathipa cpathipa changed the base branch from develop to hotfix/jan-13-23-multiple-fixes January 13, 2023 17:51
@CodyFinn-Akamai CodyFinn-Akamai merged commit c60452c into linode:hotfix/jan-13-23-multiple-fixes Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fixes for regressions or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants