-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
M3-6068: Incorrect tab selection on Linode Create #8717
M3-6068: Incorrect tab selection on Linode Create #8717
Conversation
packages/manager/src/features/linodes/LinodesCreate/SelectPlanPanel.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change should be made in SelectPlanQuantityPanel too, so that the change is reflected on the Create Kubernetes page as well. Otherwise LGTM.
Thank you @jcallahan-akamai for guiding on this, I wasn't aware of this screen. Updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 🚢
Let's point the base branch to staging
instead of develop
The base branch was changed.
c264401
to
0f46209
Compare
Description 📝
Sets plan tab to "Dedicated"
Preview 📷
Remove this section or include a screenshot or screen recording of the change
How to test 🧪
Navigate to create linode
Validate the plan tab is set to default if no plan is selected.