Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M3-5919: Update Storybook and Add New Webpack 5 Loader #8497

Merged

Conversation

bnussman
Copy link
Member

@bnussman bnussman commented Aug 15, 2022

Description 📝

Technical Explanation

  • With M3-5873: Build api-v4 and validation with tsup with backwards compatibility #8484, we now emit only singular index.js files so when older compilers try to resolve paths like @linode/api-v4/lib/linodes, the actual file lib/linodes.js does not exist now!
  • We now leverage the exports field in our package.jsons to alias paths such as @linode/api-v4/lib/** to the index.js file. Webpack 4 does not use or understand the exports field in our package.json so that's why we need this upgrade.

Preview Link 📷

https://m3-5919-update-storybook-to-.manager-ec2.pages.dev/

How to test 🧪

  • Verify that you can use the Storybook dev server with yarn storybook
  • Verify that you can build Storybook with yarn workspace linode-manager run build-storybook

@bnussman bnussman self-assigned this Aug 15, 2022
@bnussman bnussman merged commit fe9d1ae into linode:develop Aug 22, 2022
Copy link
Contributor

@DevDW DevDW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants