M3-5918: Remove babel and webpack following use of tsup
#8495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnussman
commented
Aug 12, 2022
| "axios": "~0.21.4", | ||
| "ipaddr.js": "^2.0.0", | ||
| "querystring": "^0.2.0", |
There was a problem hiding this comment.
querystring was not used anywhere so I removed it
There was a problem hiding this comment.
@bnussman It seems to be used in session.ts and linodeCreate.reducer.ts
There was a problem hiding this comment.
This is the api-v4 package.json so packages in manager should be okay
| @@ -39,54 +39,36 @@ | |||
| "unpkg": "./lib/iife/index.js", | |||
| "dependencies": { | |||
| "@linode/validation": "*", | |||
| "@types/yup": "^0.29.13", | |||
There was a problem hiding this comment.
I moved this types dependency to devDependencies
| @@ -100,5 +82,19 @@ | |||
| ".{ts,tsx}": [ | |||
| "tsc -p tsconfig.json --noEmit true --emitDeclarationOnly false" | |||
| ] | |||
| }, | |||
| "jest": { | |||
There was a problem hiding this comment.
I moved the jest config into the package.json to match how Cloud Manager does it
DevDW
approved these changes
Aug 31, 2022
HanaXu
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
api-v4andvalidationwithtsupwith backwards compatibility #8484How to test
@linode/api-v4and@linode/validationstill build and work properly in local development and in our ci pipelines