test: [M3-9143] - Cypress test for Service Transfers fetch error #11607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cliu-akamai
requested review from
jdamore-linode
and removed request for
a team
Cloud Manager UI test results🎉 500 passing tests on test run #1 ↗︎
|
|
Coverage Report: ✅ |
cliu-akamai
requested review from
bnussman-akamai and
hana-akamai
and removed request for
a team
hana-akamai
reviewed
Feb 10, 2025
Comment on lines
+506
to
+520
| // Confirm that an error message is displayed in "Received Service Transfers" panel. | ||
| cy.get('[data-qa-panel="Received Service Transfers"]') | ||
| .should('be.visible') | ||
| .within(() => { | ||
| cy.get('[data-testid="KeyboardArrowDownIcon"]').click(); | ||
| assertServiceTransfersError(serviceTransferErrorMessage); | ||
| }); | ||
|
|
||
| // Confirm that an error message is displayed is in "Sent Service Transfers" panel. | ||
| cy.get('[data-qa-panel="Sent Service Transfers"]') | ||
| .should('be.visible') | ||
| .within(() => { | ||
| cy.get('[data-testid="KeyboardArrowDownIcon"]').click(); | ||
| assertServiceTransfersError(serviceTransferErrorMessage); | ||
| }); |
There was a problem hiding this comment.
We can remove the assertServiceTransfersError function and simplify this to something like:
['Received Service Transfers', 'Sent Service Transfers'].forEach((transfer) => {
cy.get(`[data-qa-panel="${transfer}"]`)
.should('be.visible')
.within(() => {
cy.get('[data-testid="KeyboardArrowDownIcon"]').click();
// Error Icon should shows up.
cy.findByTestId('ErrorOutlineIcon').should('be.visible');
// Error message should be visible.
cy.findByText(serviceTransferErrorMessage, { exact: false }).should('be.visible');
});
})| /* | ||
| * - Confirms that an error message is displayed in both the Received and Sent tables when the requests to fetch service transfers fail. | ||
| */ | ||
| it('can display an error message when the request fails to fetch service transfer', () => { |
There was a problem hiding this comment.
Suggested change
| it('can display an error message when the request fails to fetch service transfer', () => { | |
| it('should display an error message when the request fails to fetch service transfer', () => { |
|
Looks like there's also some merge conflicts that need to be addressed |
jdamore-linode
approved these changes
Feb 12, 2025
There was a problem hiding this comment.
Thanks @cliu-akamai!
+1 to Hana's suggestions, but aside from that and the merge conflict this looks great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Add test to check an error message is displayed in both in both the Received and Sent tables when the request fails to fetch Service Transfers.
Major Changes 🔄
mockGetEntityTransfersErrorfunctioncan display an error message when the request fails to fetch service transferHow to test 🧪