test: Fix LKE update test failure following feature flag update #11113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdamore-linode
requested review from
AzureLatte
and removed request for
a team
abailly-akamai
approved these changes
Oct 16, 2024
jdamore-linode
requested review from
carrillo-erik and
jaalah-akamai
and removed request for
a team
jdamore-linode
commented
Oct 16, 2024
Comment on lines
+35
to
47
| import { mockAppendFeatureFlags } from 'support/intercepts/feature-flags'; | ||
|
|
||
| const mockNodePools = nodePoolFactory.buildList(2); | ||
|
|
||
| describe('LKE cluster updates', () => { | ||
| /* | ||
| * - Confirms UI flow of upgrading a cluster to high availability control plane using mocked data. | ||
| * - Confirms that user is shown a warning and agrees to billing changes before upgrading. | ||
| * - Confirms that details page updates accordingly after upgrading to high availability. | ||
| */ | ||
| it('can upgrade to high availability', () => { | ||
| const mockCluster = kubernetesClusterFactory.build({ | ||
| k8s_version: latestKubernetesVersion, | ||
| control_plane: { | ||
| high_availability: false, | ||
| }, | ||
| // TODO Add LKE update tests to cover flows when APL is enabled. | ||
| describe('APL disabled', () => { | ||
| beforeEach(() => { | ||
| // Mock the APL feature flag to be disabled. | ||
| mockAppendFeatureFlags({ | ||
| apl: false, | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Wow, didn't realize how massive this diff is!
This chunk of code is the only significant difference (i.e. importing mockAppendFeatureFlags, adding a new describe block, and calling mockAppendFeatureFlags in a new beforeEach hook) -- the rest of the diff is just a result of the new indentation caused by the new describe block
coliu-akamai
approved these changes
Oct 16, 2024
|
Coverage Report: ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
We recently enabled the APL feature flag for development environments which triggered a test failure in
lke-update.spec.ts. This change fixes the failing test by mocking theaplfeature flag to be disabled.Changes 🔄
List any change relevant to the reviewer.
aplfeature flag to be disabledTarget release date 🗓️
N/A
How to test 🧪
yarn cy:run -s "cypress/e2e/core/kubernetes/lke-update.spec.ts"As an Author I have considered 🤔
Check all that apply