Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DI-20837 - Handle new label property for services while selecting dashboard and Node-type filter update in DbasS #11082

Merged
merged 4 commits into from
Oct 16, 2024

Conversation

ankitaakamai
Copy link
Contributor

@ankitaakamai ankitaakamai commented Oct 10, 2024

Description 📝

Handled the new label property which shows service label when the user selects a dashboard.

Changes 🔄

  1. Handled label addition for each service type - linode & dashboard.
  2. Removed existing view showing service type in camelcase in the dropdown, it will now display label for each service.
  3. DbaaS Node Type UI filter label change from role to node_type in backend ACLP API request. (No UI display change for this commit)

Target release date 🗓️

16-10-2024

Preview 📷

Before After
Before After

How to test 🧪

  1. Login as mock and navigate to monitor tab
  2. Click on the autocomplete showing "Select A Dashboard".
  3. You should be able to test all features

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@ankitaakamai ankitaakamai marked this pull request as ready for review October 15, 2024 10:43
@ankitaakamai ankitaakamai requested a review from a team as a code owner October 15, 2024 10:43
@ankitaakamai ankitaakamai requested review from bnussman-akamai and jaalah-akamai and removed request for a team October 15, 2024 10:43
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be moved to a CloudPulse specific factory file/folder. "services" is a very generic word but is specific to CloudPulse in this case. I think that would help organization and prevent confusion

For example packages/manager/src/factories/cloudpulse/services.ts

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved the file & updated!

@ankitaakamai ankitaakamai changed the title DI-20837 - Handle new label property for services while selecting das… DI-20837 - Handle new label property for services while selecting dashboard and Node-type filter update in DbasS Oct 16, 2024
Copy link

Coverage Report:
Base Coverage: 86.96%
Current Coverage: 86.96%

@jaalah-akamai jaalah-akamai added the Add'tl Approval Needed Waiting on another approval! label Oct 16, 2024
@jaalah-akamai jaalah-akamai merged commit a431f9c into linode:develop Oct 16, 2024
22 of 23 checks passed
Copy link

cypress bot commented Oct 16, 2024

Cloud Manager E2E    Run #6686

Run Properties:  status check failed Failed #6686  •  git commit a431f9c726: DI-20837 - Handle new label property for services while selecting dashboard and ...
Project Cloud Manager E2E
Run status status check failed Failed #6686
Run duration 30m 30s
Commit git commit a431f9c726: DI-20837 - Handle new label property for services while selecting dashboard and ...
Committer ankitaakamai
View all properties for this run ↗︎

Test results
Tests that failed  Failures 2
Tests that were flaky  Flaky 7
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 435

Tests for review

Failed  oneClickApps/one-click-apps.spec.ts • 1 failed test

View Output Video

Test Artifacts
OneClick Apps (OCA) > Lists all the OneClick Apps Screenshots Video
Failed  placementGroups/delete-placement-groups.spec.ts • 1 failed test

View Output Video

Test Artifacts
Placement Group deletion > can delete with Linodes assigned when unexpected error show up and retry Screenshots Video
Flakiness  linodes/clone-linode.spec.ts • 1 flaky test

View Output Video

Test Artifacts
clone linode > can clone a Linode from Linode details page Screenshots Video
Flakiness  objectStorageGen2/bucket-create-gen2.spec.ts • 3 flaky tests

View Output Video

Test Artifacts
Object Storage Gen2 create bucket tests > can create a bucket with E0 endpoint type Screenshots Video
Object Storage Gen2 create bucket tests > can create a bucket with E1 endpoint type Screenshots Video
Object Storage Gen2 create bucket tests > can create a bucket with E3 endpoint type Screenshots Video
Flakiness  linodes/rebuild-linode.spec.ts • 1 flaky test

View Output Video

Test Artifacts
rebuild linode > cannot rebuild a provisioning linode Screenshots Video
Flakiness  placementGroups/delete-placement-groups.spec.ts • 1 flaky test

View Output Video

Test Artifacts
Placement Group deletion > can unassign Linode when unexpected error show up and reopen the dialog Screenshots Video
Flakiness  kubernetes/lke-create.spec.ts • 1 flaky test

View Output Video

Test Artifacts
LKE Cluster Creation > can create an LKE cluster Screenshots Video

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Add'tl Approval Needed Waiting on another approval! CloudPulse
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants