fix: TypeScript performance of BarPercent.tsx
#11076
Conversation
| @@ -1,10 +1,11 @@ | |||
| import { styled } from '@mui/material/styles'; | |||
| import { SxProps } from '@mui/system'; | |||
There was a problem hiding this comment.
This is another win for pnpm (#11000). By nature it won't allow imports from a package that are not an explicit dependency.
Here, we are importing from @mui/system which is not defined in our package.json
There was a problem hiding this comment.
We could use eslint to prevent imports but having a more solid foundation (a better package manager) would be a better fix
There was a problem hiding this comment.
By nature it won't allow imports from a package that are not an explicit dependency.
music to my ears
There was a problem hiding this comment.
Should these changes be applied to other instances where we are importing @mui/system as well?
There was a problem hiding this comment.
yeah, I believe so. I'll do a follow up PR for this!
bnussman-akamai
requested review from
carrillo-erik and
abailly-akamai
and removed request for
a team
bnussman-akamai
changed the title
BarPercent.tsxBarPercent.tsx
|
Coverage Report: ✅ |
| @@ -1,10 +1,11 @@ | |||
| import { styled } from '@mui/material/styles'; | |||
| import { SxProps } from '@mui/system'; | |||
There was a problem hiding this comment.
Should these changes be applied to other instances where we are importing @mui/system as well?
Description 📝
BarPercent.tsxcomponent 🏎️Preview 📷
How to test 🧪
yarn tsc --generateTrace ./trace --incremental falseand inspect withchrome://tracing)As an Author I have considered 🤔