Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change: [M3-6994] - Spell out "Configuration" on Linodes Configurations table #11046

Merged
merged 2 commits into from
Oct 4, 2024
Merged

change: [M3-6994] - Spell out "Configuration" on Linodes Configurations table #11046

merged 2 commits into from
Oct 4, 2024

Conversation

carrillo-erik
Copy link
Contributor

Description 📝

This PR changes the text copy of the column header on Linodes Configurations table.

Changes 🔄

List any change relevant to the reviewer.

  • Update the text copy from "Config" to "Configuration"

Target release date 🗓️

10/14/2024

Preview 📷

Before After
Screenshot 2024-10-03 at 2 10 41 PM Screenshot 2024-10-03 at 2 10 23 PM

How to test 🧪

Verification steps

  • Visit the "Configurations" tab on any given Linode instance and verify that the table headers reads "Configuration"

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@carrillo-erik carrillo-erik self-assigned this Oct 3, 2024
@carrillo-erik carrillo-erik requested a review from a team as a code owner October 3, 2024 21:21
@carrillo-erik carrillo-erik requested review from hana-akamai and cpathipa and removed request for a team October 3, 2024 21:21
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

Coverage Report: ✅
Base Coverage: 87.19%
Current Coverage: 87.19%

pmakode-akamai
pmakode-akamai approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@pmakode-akamai pmakode-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Thank you!

@pmakode-akamai pmakode-akamai added the Add'tl Approval Needed Waiting on another approval! label Oct 4, 2024
harsh-akamai
harsh-akamai approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@harsh-akamai harsh-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good! 👍

@harsh-akamai harsh-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Oct 4, 2024
@carrillo-erik carrillo-erik merged commit b3f86ee into linode:develop Oct 4, 2024
20 checks passed
@cypress Cypress
Copy link

cypress bot commented Oct 4, 2024

Cloud Manager E2E    Run #6621

Run Properties:  status check passed Passed #6621  •  git commit b3f86eee08: change: [M3-6994] - Spell out "Configuration" on Linodes Configurations table (#...
Project Cloud Manager E2E
Branch Review develop
Run status status check passed Passed #6621
Run duration 24m 38s
Commit git commit b3f86eee08: change: [M3-6994] - Spell out "Configuration" on Linodes Configurations table (#...
Committer carrillo-erik
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 414
View all changes introduced in this branch ↗︎

This was referenced Oct 10, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hana-akamai hana-akamai hana-akamai approved these changes

@cpathipa cpathipa cpathipa approved these changes

@pmakode-akamai pmakode-akamai pmakode-akamai approved these changes

@harsh-akamai harsh-akamai harsh-akamai approved these changes

Assignees

@carrillo-erik carrillo-erik

Labels
Approved Multiple approvals and ready to merge!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@carrillo-erik @hana-akamai @cpathipa @pmakode-akamai @harsh-akamai